migration(auth): remove HS256 path + JWTSecret config (phase 2)#60
Merged
khaliqgant merged 1 commit intomainfrom Apr 24, 2026
Merged
migration(auth): remove HS256 path + JWTSecret config (phase 2)#60khaliqgant merged 1 commit intomainfrom
khaliqgant merged 1 commit intomainfrom
Conversation
Delete the HS256 bearer verification branch, remove JWTSecret and AcceptHS256 from ServerConfig, stop reading RELAYFILE_JWT_SECRET and RELAYFILE_VERIFIER_ACCEPT_HS256, and convert the affected auth/http/mountsync tests to RS256 JWKS fixtures. Cloud phase 2 removed the TypeScript relayfile HS256 path in cloud#326 after the dual-verify rollout from relayfile#59 and the cloud#321 flag flip soaked clean, so Go can now enforce the canonical JWKS verifier path only. Keep the JWKS RS256 verifier, the wks/workspace_id dual-claim normalization, and the internal HMAC webhook authentication unchanged. Rollback: revert this commit and re-add the removed secret/flag binding in infra as a two-step rollback if HS256 must be restored. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
unsupported jwt algorithmJWTSecretandAcceptHS256frominternal/httpapi.ServerConfigand deleted the transition guardrails/inference block inNewServerWithConfigRELAYFILE_JWT_SECRETandRELAYFILE_VERIFIER_ACCEPT_HS256incmd/relayfile/main.gointernal/mountsyncintegration tests to exercise the HTTP API through RS256/JWKS as wellWhy this is safe now
Not touched
wks/workspace_idandsub/agent_nameclaim normalization remains coveredTest plan
go vet ./...go test ./internal/httpapi/...go test ./...go build ./...Rollback
Revert this PR and re-add the removed secret / flag binding at the infra level as a two-step rollback if HS256 acceptance must be restored.