feat: add agent workspace golden path#69
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dea36c0150
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const normalized = path.posix.normalize(input.replace(/\\/g, "/")); | ||
| if (normalized === "." || normalized === "") { | ||
| return ""; | ||
| } | ||
| return normalized.replace(/^\/+/, ""); |
There was a problem hiding this comment.
writeLocalFile accepts any relativePath that normalizeRelativePath returns, but that helper does not reject .. segments, so inputs like ../../outside.txt will be joined against RELAYFILE_LOCAL_DIR and can write outside the mounted workspace directory. This becomes a real escape if the path comes from agent-controlled input, and it bypasses the harness boundary the feature is meant to enforce.
Useful? React with 👍 / 👎.
| await workspace.waitForNotion({ | ||
| connectionId: notion.connectionId, | ||
| pollIntervalMs: 25, | ||
| timeoutMs: 1_000, | ||
| }); |
There was a problem hiding this comment.
In the default mock flow, createMockCloudServer keeps integration status ready: false until /mock/integrations/:provider/webhook is called, but this demo calls waitForNotion immediately and never triggers that webhook. As a result, the advertised demo:agent-workspace command times out under its own built-in mocks instead of completing successfully.
Useful? React with 👍 / 👎.
| type WorkspacePermissions | ||
| } from "./setup-types.js" | ||
|
|
||
| export const RELAYFILE_SDK_VERSION = "0.5.3" |
There was a problem hiding this comment.
The SDK now sends X-Relayfile-SDK-Version from RELAYFILE_SDK_VERSION, but this constant is hardcoded to 0.5.3 while the package is 0.6.0. Any cloud-side feature gating, telemetry, or compatibility logic keyed on this header will receive stale version data, which can misroute behavior for this release.
Useful? React with 👍 / 👎.
1 participant
Summary
Validation
Related