Skip to content

Add review-fix signoff loop skill#45

Merged
khaliqgant merged 1 commit into
mainfrom
codex/review-fix-signoff-loop-skill
May 15, 2026
Merged

Add review-fix signoff loop skill#45
khaliqgant merged 1 commit into
mainfrom
codex/review-fix-signoff-loop-skill

Conversation

@kjgbot
Copy link
Copy Markdown
Contributor

@kjgbot kjgbot commented May 15, 2026

Summary

  • add a review-fix-signoff-loop skill for fresh-context review/fix workflows
  • register the skill in prpm.json and the starter collection
  • add the skill to the README index

Validation

  • python3 /Users/khaliqgant/.codex/skills/.system/skill-creator/scripts/quick_validate.py skills/review-fix-signoff-loop
  • node -e "JSON.parse(require('fs').readFileSync('prpm.json','utf8')); console.log('prpm.json OK')"

Note: prpm publish --dry-run --package review-fix-signoff-loop could not run because PRPM requires login first.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 15, 2026

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 260e9591-9b70-48a8-ae56-9f83521a6eec

📥 Commits

Reviewing files that changed from the base of the PR and between 61543ad and 419bdd8.

📒 Files selected for processing (3)
  • README.md
  • prpm.json
  • skills/review-fix-signoff-loop/SKILL.md

📝 Walkthrough

Walkthrough

A new agent workflow skill, review-fix-signoff-loop, is registered and documented. It describes a deterministic pattern for iterating through review, implementation, validation, and dual-signoff cycles with fresh agent context per iteration, including verdict contract formats, PR signoff mechanics, and blocked-state handling.

Changes

review-fix-signoff-loop Skill Onboarding

Layer / File(s) Summary
Skill Package Registration
README.md, prpm.json
Skill entry added to README table; package metadata (name, version, description, files, tags) declared in prpm.json packages list.
Collection Integration
prpm.json, README.md
Skill added to agent-relay-starter collection as optional (required: false, version: "latest") and listed in README install instructions.
Workflow Pattern Documentation
skills/review-fix-signoff-loop/SKILL.md
Complete specification of the review-fix-signoff-loop pattern: required workflow shape (preflight, implementation, reconciliation gate, repairable validation, fresh-context dual signoff), strict verdict contract format and acceptance rules, fresh-context mechanics (workflow/channel/agent suffixing per iteration), PR signoff comment resolution and posting order, blocked-state file handling, and common mistakes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • AgentWorkforce/skills#42: Both PRs formalize the sequential "review → fix → validation → fresh-eyes dual signoff" pattern; main PR adds the review-fix-signoff-loop package registration and documentation, while #42 updates authoring guidance to require the Claude-to-Codex fresh-eyes loop.
  • AgentWorkforce/skills#38: Both PRs modify the top-level README skills/install documentation layout; #38 restructures those sections while this PR adds the new skill entry and install listing.
  • AgentWorkforce/skills#32: Both PRs update workflow-skill documentation to formalize repair-before-fail patterns and gated signoff behavior.

Poem

🐰 A loop of review, fix, and sign,
Fresh eyes each run to keep it fine,
Two verdicts green before we close,
Deterministic steps compose,
hops and files the final line.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Add review-fix signoff loop skill' directly summarizes the main change: adding a new skill to the codebase.
Description check ✅ Passed The description clearly outlines the changes (adding the skill, registering it in prpm.json and the starter collection, updating the README) and includes validation steps performed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/review-fix-signoff-loop-skill

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Re-trigger cubic

@coderabbitai coderabbitai Bot force-pushed the codex/review-fix-signoff-loop-skill branch from 61543ad to 419bdd8 Compare May 15, 2026 18:12
@khaliqgant khaliqgant merged commit da7b6f1 into main May 15, 2026
1 check was pending
@khaliqgant khaliqgant deleted the codex/review-fix-signoff-loop-skill branch May 15, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants