Require ready integration status before deploy#155
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
📝 WalkthroughWalkthroughThis PR adds a new ChangesForced Integration Reconnection Feature
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related issues
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 7 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
packages/deploy/src/connect.ts (1)
344-347: ⚡ Quick winValidate
reconnectProvidersagainst declared persona integrations to avoid silent no-ops.A typo like
--reconnect slakcis currently ignored silently, which can mislead operators into thinking a forced reconnect ran. Consider warning or failing fast for providers not present inpersona.integrations.Proposed guard
export async function connectIntegrations(input: ConnectAllInput): Promise<ConnectAllResult> { const integrations = input.persona.integrations ?? {}; + const declared = new Set(Object.keys(integrations)); + const unknownReconnect = [...new Set(input.reconnectProviders ?? [])] + .filter((provider) => !declared.has(provider)); + if (unknownReconnect.length > 0) { + input.io.warn( + `reconnect requested for undeclared integration(s): ${unknownReconnect.join(', ')}` + ); + } const outcomes: IntegrationConnectOutcome[] = [];🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/deploy/src/connect.ts` around lines 344 - 347, The loop over Object.keys(integrations) should validate entries from input.reconnectProviders to avoid silent no-ops; before using forceReconnect (and inside the surrounding function in connect.ts), iterate input.reconnectProviders (if present) and check each requested provider exists in integrations (or persona.integrations if that canonical map is used), and if any do not exist either log a warning or throw a user-facing error that names the unknown provider(s) so typos like "slakc" are surfaced; update references to reconnectProviders, integrations, and the forceReconnect computation to rely on the validated list (or bail early) so intended forced-reconnects cannot be accidentally ignored.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.trajectories/completed/2026-05/traj_61qz5tibb2lm.json:
- Line 51: The trajectory metadata currently embeds a user-specific absolute
path in the "projectId" JSON field which leaks PII and is non-portable; replace
the value of "projectId" in the JSON object (the "projectId" key inside the
trajectory file) with a repo-relative identifier or a neutral project slug
(e.g., "workforce-issue-154" or omit the field entirely), ensuring no local
filesystem paths or usernames remain; update any code that consumes this
trajectory metadata to expect the new identifier format if necessary.
In @.trajectories/index.json:
- Line 45: The index currently stores a host-local absolute path under the
"path" key (e.g. the entry in .trajectories/index.json with value
"/Users/khaliqgant/.../traj_61qz5tibb2lm.json"); update the
generation/serialization logic to record repository-relative paths instead of
absolute machine paths (for example "completed/2026-05/traj_61qz5tibb2lm.json").
Locate the code that writes entries into .trajectories/index.json (the logic
that sets the "path" field for trajectory files) and replace absolute path usage
with a repo-root-relative computation (use the repo root as base when computing
the stored path) so the index is portable and no local user/machine information
is leaked.
---
Nitpick comments:
In `@packages/deploy/src/connect.ts`:
- Around line 344-347: The loop over Object.keys(integrations) should validate
entries from input.reconnectProviders to avoid silent no-ops; before using
forceReconnect (and inside the surrounding function in connect.ts), iterate
input.reconnectProviders (if present) and check each requested provider exists
in integrations (or persona.integrations if that canonical map is used), and if
any do not exist either log a warning or throw a user-facing error that names
the unknown provider(s) so typos like "slakc" are surfaced; update references to
reconnectProviders, integrations, and the forceReconnect computation to rely on
the validated list (or bail early) so intended forced-reconnects cannot be
accidentally ignored.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 5e4a72fb-20b7-4fdc-9697-0550a1483374
📒 Files selected for processing (10)
.trajectories/completed/2026-05/traj_61qz5tibb2lm.json.trajectories/completed/2026-05/traj_61qz5tibb2lm.md.trajectories/index.jsonpackages/cli/src/deploy-command.test.tspackages/cli/src/deploy-command.tspackages/deploy/src/connect.test.tspackages/deploy/src/connect.tspackages/deploy/src/deploy.test.tspackages/deploy/src/deploy.tspackages/deploy/src/types.ts
| }, | ||
| "commits": [], | ||
| "filesChanged": [], | ||
| "projectId": "/Users/khaliqgant/Projects/AgentWorkforce/workforce-issue-154", |
There was a problem hiding this comment.
Avoid committing user-specific absolute filesystem paths in trajectory metadata.
projectId currently embeds a local path with a username, which leaks PII and makes the artifact non-portable across machines/CI. Prefer a repo-relative identifier (or omit host-local paths entirely).
Suggested change
- "projectId": "/Users/khaliqgant/Projects/AgentWorkforce/workforce-issue-154",
+ "projectId": "workforce-issue-154",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "projectId": "/Users/khaliqgant/Projects/AgentWorkforce/workforce-issue-154", | |
| "projectId": "workforce-issue-154", |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.trajectories/completed/2026-05/traj_61qz5tibb2lm.json at line 51, The
trajectory metadata currently embeds a user-specific absolute path in the
"projectId" JSON field which leaks PII and is non-portable; replace the value of
"projectId" in the JSON object (the "projectId" key inside the trajectory file)
with a repo-relative identifier or a neutral project slug (e.g.,
"workforce-issue-154" or omit the field entirely), ensuring no local filesystem
paths or usernames remain; update any code that consumes this trajectory
metadata to expect the new identifier format if necessary.
| "status": "completed", | ||
| "startedAt": "2026-05-28T07:46:09.716Z", | ||
| "completedAt": "2026-05-28T07:47:24.475Z", | ||
| "path": "/Users/khaliqgant/Projects/AgentWorkforce/workforce-issue-154/.trajectories/completed/2026-05/traj_61qz5tibb2lm.json" |
There was a problem hiding this comment.
Store trajectory index paths as repo-relative, not host-local absolute paths.
This path leaks local user/machine information and is brittle in shared environments. Use a repository-relative path so the index is portable.
Suggested change
- "path": "/Users/khaliqgant/Projects/AgentWorkforce/workforce-issue-154/.trajectories/completed/2026-05/traj_61qz5tibb2lm.json"
+ "path": ".trajectories/completed/2026-05/traj_61qz5tibb2lm.json"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "path": "/Users/khaliqgant/Projects/AgentWorkforce/workforce-issue-154/.trajectories/completed/2026-05/traj_61qz5tibb2lm.json" | |
| "path": ".trajectories/completed/2026-05/traj_61qz5tibb2lm.json" |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.trajectories/index.json at line 45, The index currently stores a host-local
absolute path under the "path" key (e.g. the entry in .trajectories/index.json
with value "/Users/khaliqgant/.../traj_61qz5tibb2lm.json"); update the
generation/serialization logic to record repository-relative paths instead of
absolute machine paths (for example "completed/2026-05/traj_61qz5tibb2lm.json").
Locate the code that writes entries into .trajectories/index.json (the logic
that sets the "path" field for trajectory files) and replace absolute path usage
with a repo-root-relative computation (use the repo root as base when computing
the stored path) so the index is portable and no local user/machine information
is leaked.
There was a problem hiding this comment.
1 issue found across 5 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".trajectories/index.json">
<violation number="1" location=".trajectories/index.json:45">
P2: Store trajectory index paths as repo-relative, not host-local absolute paths. This path leaks local user/machine information and is brittle in shared environments.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| "status": "completed", | ||
| "startedAt": "2026-05-28T07:46:09.716Z", | ||
| "completedAt": "2026-05-28T07:47:24.475Z", | ||
| "path": "/Users/khaliqgant/Projects/AgentWorkforce/workforce-issue-154/.trajectories/completed/2026-05/traj_61qz5tibb2lm.json" |
There was a problem hiding this comment.
P2: Store trajectory index paths as repo-relative, not host-local absolute paths. This path leaks local user/machine information and is brittle in shared environments.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .trajectories/index.json, line 45:
<comment>Store trajectory index paths as repo-relative, not host-local absolute paths. This path leaks local user/machine information and is brittle in shared environments.</comment>
<file context>
@@ -36,6 +36,13 @@
+ "status": "completed",
+ "startedAt": "2026-05-28T07:46:09.716Z",
+ "completedAt": "2026-05-28T07:47:24.475Z",
+ "path": "/Users/khaliqgant/Projects/AgentWorkforce/workforce-issue-154/.trajectories/completed/2026-05/traj_61qz5tibb2lm.json"
}
}
</file context>
| "path": "/Users/khaliqgant/Projects/AgentWorkforce/workforce-issue-154/.trajectories/completed/2026-05/traj_61qz5tibb2lm.json" | |
| "path": ".trajectories/completed/2026-05/traj_61qz5tibb2lm.json" |
1 participant
Summary
GET /api/v1/workspaces/<workspace>/integrations/<provider>/statusinstead of treating integration list rows as authoritative.--reconnect <provider>/--reconnect=a,bto force a fresh connect flow without an interactive confirmation.Fixes #154. Companion PRs: AgentWorkforce/cloud#1295 and AgentWorkforce/relayfile#214.
Verification
corepack pnpm --filter @agentworkforce/persona-kit build && corepack pnpm --filter @agentworkforce/runtime build && corepack pnpm --filter @agentworkforce/workload-router buildcorepack pnpm --filter @agentworkforce/deploy testcorepack pnpm --filter @agentworkforce/cli test