persona sources: rename display labels (built-in / repo / personal)

[willwashburn]

Summary

Follow-up to #83 — this commit was on the branch but didn't make the merge window.

Renames the cascade's user-facing labels to match the three conceptual tiers:

• built-in — bundled with @agentworkforce/cli (e.g. persona-maker, persona-improver). Reserved for personas about Agent Workforce itself; intentionally small.
• personal — ~/.agentworkforce/workforce/personas/. One user, many repos.
• repo — <cwd>/.agentworkforce/workforce/personas/. Codified in the working tree so the whole team gets them on checkout. Both installed library packs (the shadcn copy-and-own model, e.g. @agentrelay/personas) and hand-authored team overrides live here.

What changes for users

Surface	Before	After
agentworkforce list SOURCE column	library / cwd / user / dir:N	built-in / repo / personal / dir:N
agentworkforce sources list SOURCE column	same as above	same as above
Interactive picker (TUI) source label	same as above	same as above

What doesn't change (deliberate)

• Internal PersonaSource literals ('cwd' \| 'user' \| 'library' \| 'dir:N')
• --save-in-directory <target> flag values
• --json output of list and sources list
• Launch metadata stamp (personaSource=…)

So any tooling that pinned on the existing strings keeps working.

Implementation

• New formatPersonaSourceLabel(source) helper in local-personas.ts centralizes the mapping; tested in local-personas.test.ts.
• README gains a "Persona sources" section under the CLI heading explaining the three tiers and linking to the relay #839 worked example.
• USAGE banner for the picker spells out the four SOURCE values so the inline help matches what the user sees.

Test plan

• pnpm --filter @agentworkforce/cli test — 165/165 pass
• pnpm -r typecheck — clean
• Smoke: `agentworkforce list` now shows `built-in` / `personal` rows
• Manual sanity in a real terminal — confirm picker SOURCE column reads correctly

🤖 Generated with Claude Code

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 97988e06-5163-45e4-abf2-250b210ad270

📥 Commits

Reviewing files that changed from the base of the PR and between af701e8 and ebc1cc0.

📒 Files selected for processing (4)

• README.md
• packages/cli/src/cli.ts
• packages/cli/src/local-personas.test.ts
• packages/cli/src/local-personas.ts

✅ Files skipped from review due to trivial changes (2)

• README.md
• packages/cli/src/cli.ts

🚧 Files skipped from review as they are similar to previous changes (1)

• packages/cli/src/local-personas.ts

---

📝 Walkthrough

Walkthrough

Adds an exported helper formatPersonaSourceLabel to map internal persona source keys to user-facing labels, integrates it into CLI help text, listing tables, and the TUI picker, adds tests for the mapping, and documents persona source layers and cascade order in the README.

Changes

Persona Source Label Formatting

Layer / File(s)	Summary
Helper Function Definition packages/cli/src/local-personas.ts	New exported function formatPersonaSourceLabel maps internal persona source keys (library, user) to user-facing labels (built-in, personal) and returns other source strings unchanged.
Helper Function Tests packages/cli/src/local-personas.test.ts	Unit test added verifying library→built-in, user→personal, cwd→cwd, and passthrough behavior for dir:N.
CLI Import and Help Text packages/cli/src/cli.ts	CLI imports formatPersonaSourceLabel and updates the interactive persona picker USAGE/help text to document possible SOURCE column values.
CLI Display Rendering packages/cli/src/cli.ts	sources list, list, and TUI candidate rendering now display formatted source labels via formatPersonaSourceLabel(...) while keeping raw source values in JSON output.
User Documentation README.md	Adds "Persona sources" section describing built-in, personal, and cwd layers (including two cwd flavors) and the cascade resolution order cwd → configured dirs → personal → built-in.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• AgentWorkforce/workforce#35: Modifies CLI persona-sources/cascade surfaces and UX labeling in the same files.
• AgentWorkforce/workforce#83: Related CLI persona listing/presentation changes; overlaps with formatting and picker wiring.
• AgentWorkforce/workforce#50: Changes in local-personas.ts; touches the same module modified here.

Poem

🐰 I hop through labels, tidy and neat,
Turning library into built-in sweet,
user becomes personal, cwd stays true,
CLI lists gleam with clearer view,
A small helper hop — clarity for you!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: renaming user-facing display labels for persona sources from internal names (library/user) to user-friendly names (built-in/personal).
Description check	✅ Passed	The description is directly related to the changeset, providing clear context about the label renaming, affected surfaces, implementation details, and test results.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/persona-source-labels

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[devin-ai-integration]

Devin Review found 1 potential issue.

View 3 additional findings in Devin Review.

[devin-ai-integration]

🟡 show command outputs raw internal source label instead of user-facing label

The formatPersonaShow function at packages/cli/src/cli.ts:2288 prints the raw internal source value (e.g., library, cwd, user) directly in the human-readable output. All other human-facing displays in this PR — formatPersonaTable (packages/cli/src/cli.ts:2046), formatSourcesTable (packages/cli/src/cli.ts:1704), and buildTuiCandidates (packages/cli/src/cli.ts:3552) — now call formatPersonaSourceLabel() to map these to the new vocabulary (built-in, repo, personal). This means agentworkforce show code-reviewer will display SOURCE library while agentworkforce list displays built-in for the same persona.

(Refers to line 2288)

---

Was this helpful? React with 👍 or 👎 to provide feedback.