feat: add controlled browser preview workflow - #3207
Open
nikhilachale wants to merge 27 commits into
Open
Conversation
This reverts commit c729a66.
…trator-142/browser-preview-live-reload-pr
nikhilachale
marked this pull request as draft
July 28, 2026 10:06
…trator-142/browser-preview-live-reload-pr
whoisasx
requested changes
Jul 30, 2026
whoisasx
left a comment
Collaborator
There was a problem hiding this comment.
Requesting changes for four correctness and scalability issues in preview ownership and refresh handling. The controlled terminal-link workflow, fresh-worker behavior, external-open support, and prompt/documentation changes otherwise look coherent. Focused backend/frontend tests, race tests, typecheck, and CI pass, but focused regression probes reproduced the ownership failures described inline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ao preview, a managed preview server, or deliberate user navigationao preview <url>near the end of UI workmainand resolve the preview poller and Browser panel conflictsReview fixes
main's explicit-preview ownership instead of reintroducing automatic entrypoint discoveryTests
npm run lint(full backend tests + golangci-lint)cd backend && go test -race ./internal/preview ./internal/service/session ./internal/storage/sqlite/storecd frontend && npm testcd frontend && npm run typecheckNotes
ao preview