-
Notifications
You must be signed in to change notification settings - Fork 468
feat(frontend) Improve onboarding screen with demo project selection #3387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend) Improve onboarding screen with demo project selection #3387
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Do not merge until demo project is ready |
4dfa2a7 to
0d57ead
Compare
- Create EE GetStarted component with 'Explore demo workspace' option - Remove redundant OnboardingScreen from PostSignupForm - PostSignupForm now redirects to /get-started after survey - Keep Layout.tsx demo banner and project state changes
The Agenta logo image has aspect ratio 2.96:1 (2605x880 pixels). Changed height from 40 to 39 for width=114 to match the correct aspect ratio and prevent slight horizontal squishing. Affected pages: - get-started (OSS and EE) - auth page - post-signup form
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| onOk={closeDemoReturnModal} | ||
| onCancel={closeDemoReturnModal} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Modal 'Got it' button incorrectly dismisses hint permanently
Both the 'Got it' (OK) and 'Do not show again' (Cancel) buttons in the demo return modal call the same closeDemoReturnModal function, which sets demoReturnHintDismissed to true. This means clicking 'Got it' will permanently dismiss the modal, making it behave identically to 'Do not show again'.
Click to expand
Expected vs Actual Behavior
Expected:
- 'Got it' should only close the modal for this session (user may see it again next time)
- 'Do not show again' should permanently dismiss the modal
Actual:
Both buttons permanently dismiss the modal because they both call:
const closeDemoReturnModal = useCallback(() => {
setDemoReturnModalOpen(false)
setDemoReturnHintDismissed(true) // Always sets dismissed to true
}, [setDemoReturnHintDismissed])This contradicts the PR's test plan which states:
- "Dismiss modal → verify navigates to last used real workspace"
- "Re-enter demo → verify 'Do not show again' dismissal is respected"
Impact
Users who click 'Got it' expecting to see the hint again later will never see it, breaking the intended UX flow where only explicit 'Do not show again' should permanently suppress the modal.
Recommendation: Create separate handlers for onOk and onCancel. The onOk handler ('Got it') should only close the modal without setting demoReturnHintDismissed, while onCancel ('Do not show again') should set demoReturnHintDismissed to true:
const handleOk = useCallback(() => {
setDemoReturnModalOpen(false)
}, [])
const handleDoNotShowAgain = useCallback(() => {
setDemoReturnModalOpen(false)
setDemoReturnHintDismissed(true)
}, [setDemoReturnHintDismissed])Then use onOk={handleOk} and onCancel={handleDoNotShowAgain}.
Was this helpful? React with 👍 or 👎 to provide feedback.
fix(frontend): correct logo aspect ratio
Summary
Implements demo project workflow improvements including:
Add open demo project option in onboarding screen
Changes
State Management
lastNonDemoProjectAtom- tracks the user's last non-demo projectdemoReturnHintPendingAtom&demoReturnHintDismissedAtom- manages demo return flowcacheLastUsedProjectIdfor persisting project stateUI Improvements
OnboardingScreen
project.is_demofield from API responseTest Plan
/post-signuponboarding