[fix] workflow-related fork issues#4211
Merged
jp-agenta merged 1 commit intorelease/v0.96.8from Apr 22, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Railway Preview Environment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
POST /workflows/variants/fork silently returned {"count": 0} for any invalid/partial payload.
Made the trailing tip revision optional (fork now works when the user only supplies workflow_variant + a source ref), and converted the remaining misuses into a typed VariantForkError that the routers surface as HTTP 400 with a structured detail.
Same DAO backs workflows, applications, evaluators, and queries forks — all four endpoints are fixed by this change. Routers for workflows/applications/evaluators now translate VariantForkError → 400.
Cause
The shared fork_variant DAO is wrapped in @suppress_exceptions(), so the AttributeError raised when the caller omitted the optional revision / workflow_revision block was swallowed into None → empty response.
Fixes