[FE Enhancement] Opening evaluator spans in playground#4217
Merged
bekossy merged 28 commits intorelease/v0.96.10from Apr 28, 2026
Merged
[FE Enhancement] Opening evaluator spans in playground#4217bekossy merged 28 commits intorelease/v0.96.10from
bekossy merged 28 commits intorelease/v0.96.10from
Conversation
…p issues - Parse JSON-encoded envelope fields (`outputs`) when opening evaluator from trace - Change evaluator `outputs` port type from `object` to `string` to allow auto-detection of JSON vs plain text in editor - Skip initial empty row when opening evaluator revision, write envelope-shaped row directly - Intercept paste and Cmd+A+Delete events to prevent editor flash when switching between JSON/text modes - Add focus-on-mount
…ator-span-in-playground
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…ator-span-in-playground
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…ator-span-in-playground
…ator-span-in-playground
…pport for trace replay
…ator-span-in-playground
…ator-span-in-playground
dosubot
Bot
added
size:L
dosubot
Bot
added
size:XL
Contributor
Railway Preview Environment
Updated at 2026-04-28T13:25:50.737Z |
…d of navigating away - Keep trace drawer open when opening spans in playground (no app reference) - Use workflow revision drawer overlay for ephemeral playground sessions - Navigate to app playground only for spans with app references (closes trace drawer) - Force expanded mode for span replay to show full playground with execution panel - Prevent closing programmatically-opened drawers on unrelated route changes - Add expanded
….com/Agenta-AI/agenta into improve/evaluator-span-in-playground
…n has empty parameters - Add `findDescendantParameters` helper to recursively search child spans for non-empty `ag.data.parameters` - Use descendant parameters as fallback when active span has empty config - Fixes playground showing empty state for workflow/task/agent/chain spans that wrap LLM calls - Handles JSON-encoded parameter strings during tree walk - Update comments to clarify span replay behavior and drawer context usage
dosubot
Bot
added
size:XXL
…luator span app context - Skip paste-triggered JSON mode detection for object/array schema fields (already pinned to JSON) - Preserves cursor position and existing JSON content when pasting into schema-typed fields - Set `appId: undefined` for evaluator spans in `openFromTraceAtom` to force workflow drawer - Aligns evaluator span handling with evaluator-revision branch behavior - Add comments clarifying schema-typed paste behavior and
mmabrouk
approved these changes
Apr 28, 2026
Member
mmabrouk
left a comment
mmabrouk
left a comment
There was a problem hiding this comment.
Thanks @ardaerzin !
We should test this with all evaluators types to make sure it is correct. We should especially test with LLM-as-a-judge with a custom output.
Contributor
Author
I've tested this locally using a variety, from exact match to llm as judge. But @bekossy, please make sure that the qa scope includes this |
…ring character-by-character edits - Implement sticky JSON mode detection that persists during single-character edits - Prevent Lexical editor remount when transiently breaking JSON shape (e.g., deleting closing `}`) - Re-detect JSON mode on bulk replacements (paste, Cmd+A+Delete) when length delta exceeds 1 - Track previous value and detection state with refs to enable sticky behavior - Maintain immediate detection on first render to
bekossy
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tba...
Testing
Verified locally
QA follow-up
Demo
Checklist
Contributor Resources