Skip to content

[feat] Add minimax API support #4223

Merged
bekossy merged 9 commits intoAgenta-AI:release/v0.96.10from
anshk8:feat/add-minimax-provider
Apr 28, 2026
Merged

[feat] Add minimax API support #4223
bekossy merged 9 commits intoAgenta-AI:release/v0.96.10from
anshk8:feat/add-minimax-provider

Conversation

@anshk8
Copy link
Copy Markdown
Contributor

@anshk8 anshk8 commented Apr 24, 2026

Summary

Testing

Verified locally

Local Verification:
(Note: MinMax requires $25USD minimum to test which I didn't purchase, if anyone does have credits and could help verify would be appreciated 😄 )

  • I tested out setting MINMAX_API_KEY inside my .env file and startup Agenta. If no key present, I get error asking for API key. If API key is present, I get "insufficient funds" error, meaning the MinMax is being called properly!
  • Also verified and got same behaviour as above for setting Standard Provider and Custom Provider in settings

Added or updated tests

Inside api/oss/tests/pytest/unit/secrets/test_utils.py I extended the existing fakeVault test so a provider_key with StandardProviderKind.MINIMAX is mapped to MINIMAX_API_KEY in the dict returned by get_user_llm_providers_secrets().

QA follow-up

N/A

Demo

Screen.Recording.2026-04-24.at.9.37.31.PM.mov
  • Note The Insufficient Balance and Key Not provided errors are expected, just wanted to show that it exists on all 3 enviornments

Checklist

  • I have included a video or screen recording for UI changes, or marked Demo as N/A
  • Relevant tests pass locally
  • Relevant linting and formatting pass locally
  • I have signed the CLA, or I will sign it when the bot prompts me

Contributor Resources

Copilot AI review requested due to automatic review settings April 24, 2026 02:01
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 24, 2026

@anshk8 is attempting to deploy a commit to the agenta projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds MiniMax as a supported LLM provider across the OSS stack (API, web UI, SDK) by wiring in the provider slug (minimax) and its API key env var (MINIMAX_API_KEY) anywhere provider kinds/secrets are enumerated.

Changes:

  • Added minimax to provider/secret enums and provider label maps (web + API + SDK client types).
  • Added MINIMAX_API_KEY to provider secret transform/mapping utilities and enabled-provider detection.
  • Added MiniMax models to the SDK’s supported model catalog and documented the env var in docker-compose example env files.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
web/oss/src/state/app/atoms/vault.ts Maps MINIMAX_API_KEY to the SecretDTOProvider.MINIMAX kind when creating/updating standard provider secrets.
web/oss/src/lib/helpers/llmProviders.ts Adds MiniMax to provider lists and secret-to-env-var transformation mapping for UI/provider settings.
web/oss/src/lib/Types.ts Extends SecretDTOProvider and PROVIDER_LABELS with minimax / “MiniMax”.
web/oss/src/components/pages/evaluations/onlineEvaluation/hooks/useEvaluatorTypeFromConfigs.ts Treats minimax tokens as LLM/AI evaluators for category inference.
sdk/agenta/sdk/utils/assets.py Adds MiniMax models under the minimax provider to the SDK model catalog.
sdk/agenta/sdk/engines/running/runners/daytona.py Passes MINIMAX_API_KEY into Daytona sandboxes when present in vault secrets.
sdk/agenta/client/backend/types/standard_provider_kind.py Updates generated standard provider kind union to include minimax.
sdk/agenta/client/backend/types/custom_provider_kind.py Updates generated custom provider kind union to include minimax.
hosting/docker-compose/oss/env.oss.gh.example Documents MINIMAX_API_KEY in the OSS GitHub example env file.
hosting/docker-compose/oss/env.oss.dev.example Documents MINIMAX_API_KEY in the OSS dev example env file.
api/oss/src/utils/env.py Adds minimax to LLM config env loading and enabled-provider detection.
api/oss/src/models/api/evaluation_model.py Adds minimax to the evaluation LM provider enum (MINIMAX_API_KEY).
api/oss/src/core/secrets/enums.py Adds MINIMAX = "minimax" to standard/custom provider kind enums.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@anshk8 anshk8 changed the title Feat/add minimax provider [feat] Add minimax API support Apr 24, 2026
Copilot AI review requested due to automatic review settings April 25, 2026 01:28
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread web/packages/agenta-ui/src/LLMIcons/assets/MiniMax.tsx Outdated
Comment thread web/packages/agenta-ui/src/LLMIcons/assets/MiniMax.tsx Outdated
@anshk8 anshk8 marked this pull request as ready for review April 25, 2026 01:40
Copilot AI review requested due to automatic review settings April 25, 2026 01:40
@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Apr 25, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread web/packages/agenta-ui/src/LLMIcons/assets/MiniMax.tsx Outdated
Copilot AI review requested due to automatic review settings April 28, 2026 07:22
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

@jp-agenta jp-agenta changed the base branch from main to release/v0.96.10 April 28, 2026 13:50
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Apr 28, 2026
@bekossy bekossy merged commit e87fafd into Agenta-AI:release/v0.96.10 Apr 28, 2026
13 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files. tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants