Skip to content

fix/Removed duplicate Mistral option#4230

Merged
bekossy merged 6 commits intoAgenta-AI:release/v0.96.10from
anshk8:fix/duplicate-mistral-provider
Apr 28, 2026
Merged

fix/Removed duplicate Mistral option#4230
bekossy merged 6 commits intoAgenta-AI:release/v0.96.10from
anshk8:fix/duplicate-mistral-provider

Conversation

@anshk8
Copy link
Copy Markdown
Contributor

@anshk8 anshk8 commented Apr 27, 2026

Summary

  • Mistral was shown twice inside the dropdown for adding a Custom or Standard provider
  • This PR fixes the UI showing Mistral option twice, one was being displayed for the legacy 'MistralAI' and one for 'Mistral'
  • The provider dropdown listed Mistral twice because the frontend enumerated both mistral and legacy mistralai, and both labels are “Mistral AI
  • In the backend, inside api/oss/src/core/secrets/dtos.py , Backend already normalizes legacy MistralAI to canonical Mistral lines 100-102, see below
            # Accept the legacy provider slug on input, but persist the canonical value.
            if data.get("kind") == StandardProviderKind.MISTRALAI.value:
                data["kind"] = StandardProviderKind.MISTRAL.value

  • Now UI is aligned with backend

Testing

Verified locally

  • Locally verified, I can set Mistral API key inside Custom and Standard provider and successfully run a completion inside Playground
  • Locally, verified I see one Mistral option

Added or updated tests

N/A

QA follow-up

N/A

Demo

Before:
image

After:
image

Checklist

  • I have included a video or screen recording for UI changes, or marked Demo as N/A
  • Relevant tests pass locally
  • Relevant linting and formatting pass locally
  • I have signed the CLA, or I will sign it when the bot prompts me

Contributor Resources


Copilot AI review requested due to automatic review settings April 27, 2026 23:35
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 27, 2026

@anshk8 is attempting to deploy a commit to the agenta projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aligns the Model Registry “Configure Provider” UI with backend canonicalization by preventing the legacy mistralai provider slug from appearing as a separate option, eliminating the duplicate “Mistral AI” entry in the provider dropdown.

Changes:

  • Filtered the legacy SecretDTOProvider.MISTRALAI slug out of the provider dropdown options.
  • Normalized any pre-selected legacy mistralai provider value to the canonical mistral when populating the form.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…Drawer/assets/ConfigureProviderDrawerContent.tsx

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 27, 2026 23:40
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@anshk8 anshk8 marked this pull request as ready for review April 27, 2026 23:44
@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working Frontend labels Apr 27, 2026
@jp-agenta jp-agenta changed the base branch from main to release/v0.96.10 April 28, 2026 13:48
Copilot AI review requested due to automatic review settings April 28, 2026 15:46
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Apr 28, 2026
@bekossy bekossy merged commit 6df2104 into Agenta-AI:release/v0.96.10 Apr 28, 2026
13 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Frontend lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants