Skip to content

[fix] Resolve interferring tests#4290

Closed
junaway wants to merge 10 commits intorelease/v0.99.3from
fix/test-interference
Closed

[fix] Resolve interferring tests#4290
junaway wants to merge 10 commits intorelease/v0.99.3from
fix/test-interference

Conversation

@junaway
Copy link
Copy Markdown
Contributor

@junaway junaway commented May 7, 2026

No description provided.

Copilot AI review requested due to automatic review settings May 7, 2026 11:36
@vercel
Copy link
Copy Markdown

vercel Bot commented May 7, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agenta-documentation Error Error May 7, 2026 5:50pm

Request Review

@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label May 7, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 7, 2026 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1a10e959-fa66-47de-a5aa-6b20b75ac2bb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/test-interference

Comment @coderabbitai help to get the list of available commands and usage tips.

@dosubot dosubot Bot added the tests label May 7, 2026
Copilot AI reviewed May 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to stop OSS acceptance/integration tests from interfering with each other by enforcing OSS single-tenant behavior during “simple account” creation (so creating users doesn’t keep creating new org/workspace/project graphs). It also updates the PR preview workflow to run tests for all packages.

Changes:

  • Add an OSS-only code path for POST /admin/simple/accounts/ that attaches new users to the pre-existing OSS singleton org/workspace/default project.
  • Introduce OssMultiOrgNotSupportedError and map it to a 400 in the FastAPI router.
  • Update the PR preview workflow to run Railway tests with packages: all.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
api/oss/src/core/accounts/service.py Adds OSS-only simple-account creation path and rejects multi-org inputs in OSS mode.
api/oss/src/core/accounts/errors.py Adds a new OSS-specific domain error for unsupported multi-org inputs.
api/oss/src/apis/fastapi/accounts/router.py Maps the new OSS error to a 400 Bad Request.
.github/workflows/14-check-pr-preview.yml Runs Railway preview tests for all packages instead of web-only.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread api/oss/src/core/accounts/service.py Outdated
Comment thread api/oss/src/core/accounts/service.py
Comment thread api/oss/src/core/accounts/service.py Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026 •
edited
Loading

Railway Preview Environment
Status Destroyed (PR converted to draft)

Updated at 2026-05-07T17:22:07.625Z

@jp-agenta @claude
fix(api): address PR review on OSS simple-accounts path
f2eb9f2 
- Replace incorrect get_workspaces(organization_id=...) call (no kwarg) with
  get_project_by_organization_id + admin_get_workspace_by_id — both return
  Optional and avoid the NoResultFound bubble from get_default_project_id_from_workspace.
- Reject entry.api_keys in OSS mode (was silently ignored). Surfaces the
  intent via OssMultiOrgNotSupportedError with a message pointing callers
  to options.create_api_keys for the default key.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 7, 2026 13:15
Copilot AI reviewed May 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

Comment thread api/oss/src/core/accounts/service.py Outdated
Comment thread api/oss/src/core/accounts/service.py
Comment thread api/oss/src/core/accounts/service.py
@dosubot dosubot Bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels May 7, 2026
Copilot AI review requested due to automatic review settings May 7, 2026 16:24
Copilot AI reviewed May 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 17 out of 19 changed files in this pull request and generated 3 comments.

Comment thread api/oss/src/services/db_manager.py Outdated
Comment thread api/oss/src/utils/env.py Outdated
Comment thread api/oss/src/core/accounts/service.py Outdated
Copilot AI review requested due to automatic review settings May 7, 2026 16:54
Copilot AI reviewed May 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 24 out of 26 changed files in this pull request and generated 2 comments.

Comment thread api/oss/src/services/db_manager.py Outdated
Comment thread api/oss/src/core/accounts/service.py Outdated
Copilot AI review requested due to automatic review settings May 7, 2026 17:11
Copilot AI reviewed May 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 26 out of 28 changed files in this pull request and generated 1 comment.

Comment thread api/oss/src/core/accounts/service.py Outdated
@junaway junaway marked this pull request as draft May 7, 2026 17:21
@junaway junaway marked this pull request as ready for review May 7, 2026 17:30
@junaway junaway marked this pull request as draft May 7, 2026 17:30
@junaway junaway marked this pull request as ready for review May 7, 2026 17:32
@junaway junaway closed this May 7, 2026
@junaway junaway reopened this May 7, 2026
@junaway junaway closed this May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

size:XL This PR changes 500-999 lines, ignoring generated files. tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@junaway @jp-agenta