[fix] Resolve corrupted docker files#4355
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Reverts the SDK/client injection workaround by making the Python api and services images build from the repo root, which matches how their Dockerfile.gh files already reference ./api/..., ./services/..., ./sdks/python, and ./clients/python. This removes the brittle copy-before-build step in CI and local helpers.
Changes:
- Switch all
gh/gh.local/gh.ssl/ee.ghcompose files and the Railway build script to use the repo root as build context with theapi/.../services/...Dockerfile path prefix. - Remove the SDK/client copy + cleanup trap logic from
run.shandbuild-and-push-images.sh. - Update OSS and EE README docs to describe the new root-context build model.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| hosting/railway/oss/scripts/build-and-push-images.sh | Drops SDK/client copy + trap; builds api & services with repo root context. |
| hosting/railway/oss/README.md | Documents that no SDK injection step is needed. |
| hosting/docker-compose/run.sh | Removes the gh.local SDK/client copy block and cleanup trap. |
| hosting/docker-compose/oss/docker-compose.gh.yml | Updates commented-out build sections to root context. |
| hosting/docker-compose/oss/docker-compose.gh.ssl.yml | Switches api/services builds to root context. |
| hosting/docker-compose/oss/docker-compose.gh.local.yml | Switches api/services builds to root context. |
| hosting/docker-compose/tmp/docker-compose.ee.gh.override.yml | Switches EE api/services overrides to root context. |
| hosting/docker-compose/ee/docker-compose.gh.local.yml | Switches EE api/services builds to root context. |
| hosting/docker-compose/ee/README.md | Documents repo-root build context for API & Services. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.