Skip to content

[FE Chore] Disable new behavior behind a flag#4384

Merged
ardaerzin merged 4 commits into
release/v0.100.1from
fe-chore/disable-app-workflow-pages-for-evaluators
May 21, 2026
Merged

[FE Chore] Disable new behavior behind a flag#4384
ardaerzin merged 4 commits into
release/v0.100.1from
fe-chore/disable-app-workflow-pages-for-evaluators

Conversation

@ardaerzin
Copy link
Copy Markdown
Contributor

Summary

disabled new navigation behavior

Testing

Verified locally

check evaluator behavior [create / navigate]

Checklist

  • I have included a video or screen recording for UI changes, or marked Demo as N/A
  • Relevant tests pass locally
  • Relevant linting and formatting pass locally
  • I have signed the CLA, or I will sign it when the bot prompts me

Contributor Resources

@vercel
Copy link
Copy Markdown

vercel Bot commented May 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agenta-documentation Ready Ready Preview, Comment May 21, 2026 7:49am

Request Review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 20, 2026

Review Change Stack

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a2dc0560-3954-44dd-bfb2-040c62b57668

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

This PR introduces EVALUATOR_FULL_PAGE_NAV_ENABLED, a feature flag currently disabled, to gate evaluator full-page playground navigation. Four components import and consistently apply this flag to control row-click navigation, URL routing behavior, sidebar switcher visibility, and post-create navigation paths.

Changes

Evaluator Full-Page Navigation Feature Flag

Layer / File(s) Summary
Feature flag definition and export
web/oss/src/state/workflow/flags.ts, web/oss/src/state/workflow/index.ts
EVALUATOR_FULL_PAGE_NAV_ENABLED is defined as false with documentation describing its scope across four navigation touchpoints, then re-exported through the workflow state module.
Evaluator navigation components gating
web/oss/src/components/Evaluators/index.tsx, web/oss/src/components/PlaygroundRouter/index.tsx, web/oss/src/components/Sidebar/components/WorkflowEntityCard.tsx, web/oss/src/components/WorkflowRevisionDrawerWrapper/index.tsx
Row-click navigation, playground routing guard, sidebar evaluator switcher visibility, and post-create navigation all import and apply the flag to gate their full-page navigation logic. When disabled, navigation falls back to drawer-based or existing flow behavior.

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: introducing a feature flag to disable new navigation behavior across evaluator-related components.
Description check ✅ Passed The description is related to the changeset, mentioning that new navigation behavior was disabled and that evaluator behavior was tested locally.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fe-chore/disable-app-workflow-pages-for-evaluators

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ardaerzin ardaerzin marked this pull request as ready for review May 20, 2026 13:04
@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. Frontend labels May 20, 2026
@ardaerzin ardaerzin changed the base branch from main to release/v0.100.1 May 20, 2026 13:10
@ardaerzin ardaerzin merged commit 4d43ddb into release/v0.100.1 May 21, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Frontend size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant