Skip to content

Increase DEFAULT_MAX_RENDER_DEPTH in BeautifiedJsonView to 100#4389

Merged
junaway merged 3 commits into
release/v0.100.1from
code/fix-issue-in-agenta-ai-repository
May 21, 2026
Merged

Increase DEFAULT_MAX_RENDER_DEPTH in BeautifiedJsonView to 100#4389
junaway merged 3 commits into
release/v0.100.1from
code/fix-issue-in-agenta-ai-repository

Conversation

@ashrafchowdury
Copy link
Copy Markdown
Contributor

@ashrafchowdury ashrafchowdury commented May 20, 2026

Motivation

  • Allow deep trace payloads to remain expandable in the beautified JSON view so large/nested debugging traces are easier to inspect while keeping UI guardrails through collapsible rendering and inherent JSON size limits.

Description

  • Raise DEFAULT_MAX_RENDER_DEPTH from 5 to 100 in BeautifiedJsonView.tsx and add a clarifying comment about the intent and existing guardrails.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agenta-documentation Ready Ready Preview, Comment May 21, 2026 7:54am

Request Review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 20, 2026

Review Change Stack

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7c966b5d-f5bf-4b0a-8921-a43cfe078c0b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

The default maximum recursion depth for rendering beautified JSON trees is increased from 5 to 100, with comments documenting the expanded behavior and existing safeguards.

Changes

JSON Beautifier Render Depth

Layer / File(s) Summary
Default render depth constant update
web/oss/src/components/DrillInView/BeautifiedJsonView.tsx
DEFAULT_MAX_RENDER_DEPTH constant raised from 5 to 100 with comments noting deeper trace expansion in beautified mode and confirming existing guardrails remain active.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • Agenta-AI/agenta#4343: Both PRs modify the recursive depth-limited rendering in BeautifiedJsonView.tsx; the related PR introduces the collapsible tree structure with depth guardrails, and this PR adjusts the default depth threshold.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title directly and clearly describes the main change: increasing DEFAULT_MAX_RENDER_DEPTH to 100 in BeautifiedJsonView, which matches the primary modification in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The pull request description clearly describes the changes being made (increasing DEFAULT_MAX_RENDER_DEPTH from 5 to 100) and provides meaningful context about the motivation for allowing deeper trace payloads to remain expandable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch code/fix-issue-in-agenta-ai-repository

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. Frontend UX labels May 20, 2026
@ashrafchowdury ashrafchowdury linked an issue May 20, 2026 that may be closed by this pull request
@junaway junaway changed the base branch from main to release/v0.100.1 May 21, 2026 06:09
@junaway junaway merged commit 71be50d into release/v0.100.1 May 21, 2026
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex Frontend size:XS This PR changes 0-9 lines, ignoring generated files. UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Beautified JSON inputs stop expanding after five levels

3 participants