[research] Additional fixes required for proper entity retrieval#4424
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a design follow-up document that enumerates remaining gaps in retrieve reference resolution (entity-ref vs environment-ref), and outlines a concrete remediation plan (C-items) mapped to current discrepancies (D-items).
Changes:
- Introduces a structured “five rules” model for retrieve reference resolution and path-mixing behavior.
- Documents current behavioral discrepancies (D1–D15) and proposed implementation steps (C1–C10), with suggested landing order.
- Adds doc references to prior audit work and highlights needed test/doc follow-ups.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ### D6. Docs site lies about behavior | ||
|
|
||
| PR #4418/#4422 fixed the per-field descriptions on the 6 request models. But | ||
| [`02-fetch-prompt-programatically.mdx`](../../docs/prompt-engineering/integrating-prompts/02-fetch-prompt-programatically.mdx) |
| ### D6. Docs site lies about behavior | ||
|
|
||
| PR #4418/#4422 fixed the per-field descriptions on the 6 request models. But | ||
| [`02-fetch-prompt-programatically.mdx`](../../docs/prompt-engineering/integrating-prompts/02-fetch-prompt-programatically.mdx) |
|
|
||
| --- | ||
|
|
||
| ## Section 1 — The five rules |
| environment's deployment map. Evaluators reject path-mixed requests with 400. | ||
| Neither is documented as the rule; both are observable behavior. | ||
|
|
||
| ### 2.a — Unique, minimal, sufficient, consistent |
|
|
||
| **Expected behavior:** 200, returned revision matches the references. | ||
|
|
||
| ### 2.b — Unique, redundant, sufficient, consistent |
| 2.d. | ||
|
|
||
| **Expected behavior:** 200. Redundancy is silently fine when it's consistent. | ||
|
|
||
| ### 2.c — Unique, redundant, sufficient, inconsistent |
| **Expected behavior:** 400 (or 422) naming the conflicting field. Today, all | ||
| inconsistencies in this case are silently absorbed — see D1 and D10. | ||
|
|
||
| ### 2.d — Unique, minimal, insufficient, consistent |
| deployment under that key, etc.). All fallback rules must be deterministic | ||
| and consistent across entities. | ||
|
|
||
| ### 2.e — Non-unique or insufficient |
mmabrouk
merged commit a4869d7
into
fix/workflows-retrieve-guardrails
No description provided.