fix(frontend): seed parameter defaults for custom URL workflows#4440
Merged
mmabrouk merged 2 commits intoMay 27, 2026
Merged
Conversation
Custom URL workflows (those with a service URL but no agenta URI) had
two issues that made the playground config form render empty even when
their /openapi.json defined parameter defaults.
First, the openapi fallback in workflowEntityAtomFamily resolved the
parameter SCHEMA from appSchemas.parameters but never seeded initial
parameter VALUES. The form iterates parameter values, not schema
properties, so an empty values dict produces an empty form regardless
of how complete the schema is. The fix extracts defaults from the
schema via extractDefaultsFromSchema (hoisted out of createFromTemplate
and re-exported from the workflow api barrel) and assigns them to
resolvedParams. This mirrors the catalog template path, which already
fills parameters from schema defaults at create time. The merge guard
is hardened to also treat an empty object as 'no stored params', so
the seeding still applies if any future code path stores {} instead of
leaving parameters undefined.
Second, configurationSelectorAtomFamily and configurationAtomFamily
read from workflowBaseEntityAtomFamily, which deliberately skips the
inspect/openapi schema-resolution layer. That meant the form's values
selector never saw the seeded defaults even after the fix above. Both
selectors now read from workflowEntityAtomFamily (the merged atom).
All 17 callers are in playground or execution contexts where the
merged atom is already in the dependency graph, so the swap adds no
new schema-fetch subscriptions in practice. isDirty intentionally
still reads from the base atom and is unaffected.
The seeded defaults live only in the merged atom in memory and are
not persisted. On every playground open before the first save, the
form re-renders with the openapi defaults. The first save commits
them as a real revision; from then on the merge guard sees stored
parameters and the seeding is a no-op.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dosubot
Bot
added
size:M
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR extends workflow configuration to populate parameter defaults from JSON Schema definitions. A utility function is exported, integrated into the workflow entity store to lazily seed missing parameters from OpenAPI schemas, and exposed through Jotai atoms so configuration forms receive the merged defaults. ChangesSchema defaults integration
🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ardaerzin
approved these changes
May 26, 2026
Contributor
Railway Preview Environment
Updated at 2026-05-27T08:04:21.277Z |
mmabrouk
merged commit 584ff4b
into
feat/trace-observability-batch
31 of 32 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Custom URL workflows (those with a service URL but no agenta URI) had two issues that made the playground config form render empty even when their
/openapi.jsondefined parameter defaults.workflowEntityAtomFamilyresolved the parameter schema but never seeded initial parameter values. The form iterates values, not schema properties, so the form rendered empty. The fix extracts defaults from the schema viaextractDefaultsFromSchema(hoisted out ofcreateFromTemplate.tsand re-exported from the workflow api barrel) and assigns them toresolvedParams. This mirrors the catalog template path, which already fillsparametersfrom schema defaults at create time.configurationSelectorAtomFamilyandconfigurationAtomFamilyread fromworkflowBaseEntityAtomFamily, which deliberately skips the inspect/openapi schema-resolution layer. That meant the form's values selector never saw the seeded defaults. Both selectors now read from the mergedworkflowEntityAtomFamily. All 17 callers are in playground or execution contexts where the merged atom is already in the dependency graph, so the swap adds no new schema-fetch subscriptions in practice.isDirtyintentionally still reads from the base atom and is unaffected.The merge guard is hardened to treat an empty object the same as "no stored params", so the seeding still applies if any future code path stores
{}instead of leavingparametersundefined.Lifecycle (documented in the seeding block)
The seeded defaults live only in the merged atom in memory. They are not persisted. On every playground open before the first save, the form re-renders with the openapi defaults. The first save commits them as a real revision; from then on the merge guard sees stored parameters and the seeding becomes a no-op, so subsequent opens read the saved values directly. This mirrors the catalog template behavior except that for custom URL apps we do it lazily on first open instead of eagerly at create time.
Files
web/packages/agenta-entities/src/workflow/api/createFromTemplate.ts— exportextractDefaultsFromSchema; update docstringweb/packages/agenta-entities/src/workflow/api/index.ts— re-exportextractDefaultsFromSchemafrom the workflow api barrelweb/packages/agenta-entities/src/workflow/state/store.ts— seedresolvedParamsfrom openapi defaults; harden the merge guard; document lifecycleweb/packages/agenta-entities/src/workflow/state/molecule.ts— switchconfigurationSelectorAtomFamilyto read from the merged entity atomweb/packages/agenta-entities/src/workflow/state/runnableSetup.ts— same switch forconfigurationAtomFamilyTest plan
pnpm lint-fixinweb/(passes on this branch)/openapi.jsondefinesag_config.properties.<key>.defaultdata.parameters