Skip to content

[FE fix] Improve trace output styling#4478

Merged
mmabrouk merged 3 commits into
release/v0.100.6from
fe-fix/trace-output-styling
May 28, 2026
Merged

[FE fix] Improve trace output styling#4478
mmabrouk merged 3 commits into
release/v0.100.6from
fe-fix/trace-output-styling

Conversation

@ardaerzin
Copy link
Copy Markdown
Contributor

Summary

fixes the reported issue:

The outputs in tracing when strings are shown with grey background (even in markdown) we should simply use white background like in pretty

Testing

QA follow-up

check the trace output information in the drawer

Checklist

  • I have included a video or screen recording for UI changes, or marked Demo as N/A
  • Relevant tests pass locally
  • Relevant linting and formatting pass locally
  • I have signed the CLA, or I will sign it when the bot prompts me

Contributor Resources

ardaerzin added 2 commits May 28, 2026 19:14
Match the beautified/pretty view styling so string and markdown outputs
on the span Overview tab render on white instead of grey.
The TextModeViewer inherited the default editor font size (~14px),
making outputs render larger than the BeautifiedJsonView inputs (12.5px).
Force the editor input to 12.5px so both sides match.
@vercel
Copy link
Copy Markdown

vercel Bot commented May 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agenta-documentation Ready Ready Preview, Comment May 28, 2026 8:07pm

Request Review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 28, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5833dffd-a67e-444f-8ebf-9f4e1c311063

📥 Commits

Reviewing files that changed from the base of the PR and between 57a499c and 3ae4398.

📒 Files selected for processing (1)
  • web/oss/src/components/DrillInView/TraceSpanDrillInView.tsx

📝 Walkthrough

Summary by CodeRabbit

  • Style
    • Updated background colors and visual styling in the trace viewer.
    • Refined editor UI appearance with improved typography and layout adjustments.

Walkthrough

This PR updates Tailwind styling in the TraceSpanDrillInView component. The editor provider's className selector is revised with updated border, rounding, and internal spacing/background/typography styles, and the text/markdown mode wrapper background color changes from light gray to white.

Changes

Styling Updates

Layer / File(s) Summary
Editor and wrapper container styling
web/oss/src/components/DrillInView/TraceSpanDrillInView.tsx
TextModeViewer editor className Tailwind selectors are updated, and the wrapper container <div> background changes from bg-[#F6F8FB] to bg-white.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: styling improvements to trace output rendering in the frontend, specifically updating background colors and typography in the text/markdown view.
Description check ✅ Passed The description is directly related to the changeset, explaining the specific issue (grey background in trace outputs) and the fix (white background to match the pretty view), with appropriate QA testing notes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fe-fix/trace-output-styling

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ardaerzin ardaerzin marked this pull request as ready for review May 28, 2026 20:06
@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. Frontend UI labels May 28, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 28, 2026

Actionable comments posted: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 28, 2026

Railway Preview Environment

Status Destroyed (PR closed)

Updated at 2026-05-28T21:00:12.541Z

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 28, 2026
@mmabrouk mmabrouk changed the base branch from main to release/v0.100.6 May 28, 2026 20:59
@mmabrouk mmabrouk merged commit 70bf500 into release/v0.100.6 May 28, 2026
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Frontend lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files. UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants