Skip to content

fix(frontend): remove copyright and social-links footer bar#4550

Merged
bekossy merged 2 commits into
release/v0.102.0from
fix/remove-footer-bar
Jun 5, 2026
Merged

fix(frontend): remove copyright and social-links footer bar#4550
bekossy merged 2 commits into
release/v0.102.0from
fix/remove-footer-bar

Conversation

@mmabrouk
Copy link
Copy Markdown
Member

@mmabrouk mmabrouk commented Jun 4, 2026

Context

Every platform page rendered a bottom bar with the GitHub, LinkedIn, and X icons and a "Copyright © | Agenta." line. We want it gone.

Changes

Removed the footer from the app layout (web/oss/src/components/Layout/Layout.tsx): the <FooterIsland> block, its 30px spacer, the dynamic FooterIsland import, and the now-unused icon / Space / Link imports.

Deleted the FooterIsland component, which was only used by that layout.

Cleaned up the styles (assets/styles.ts): dropped the footer, footerLeft, and footerLinkIcon rules, and removed the footerHeight plumbing. A useResizeObserver existed only to measure the footer and feed its height into the content style's height/marginBottom calc. With no footer, that measurement is always zero, so the observer, the footerHeight prop threaded through AppWithVariants, and the calc are all gone. StyleProps is now a plain alias of the shared style props (it only carried footerHeight).

EE uses this same OSS layout, so the bar is removed everywhere.

Tests

  • npx eslint on the two edited files: passes.
  • Searched web/oss, web/ee, and web/packages for FooterIsland, footerHeight, footer, footerLeft, footerLinkIcon: no remaining source references.

Drop the bottom bar that showed the GitHub, LinkedIn, and X icons and the
'Copyright © <year> | Agenta.' line from the platform layout.

Remove the FooterIsland component, its styles, and the footerHeight resize
observer that only existed to size the footer.
@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. Frontend labels Jun 4, 2026
@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agenta-documentation Ready Ready Preview, Comment Jun 5, 2026 9:21am

Request Review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 4, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 80410814-e501-482f-8cac-82dc1e0d7d9c

📥 Commits

Reviewing files that changed from the base of the PR and between b5d2676 and 8c270b5.

📒 Files selected for processing (1)
  • web/oss/src/components/Layout/Layout.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • web/oss/src/components/Layout/Layout.tsx

📝 Walkthrough

Summary by CodeRabbit

  • Refactor
    • Removed the footer section with social links and copyright from the app layout.
    • Simplified layout plumbing by eliminating dynamic footer height handling.
    • Updated content-area styling to use fixed spacing and full-height behavior.

Walkthrough

This PR removes footer rendering and its related styling and wiring from the web/oss Layout: the FooterIsland component and footer JSX are deleted, footerHeight is removed from styles and layout logic, and footer-specific style rules and imports are removed.

Changes

Footer island removal

Layer / File(s) Summary
Style system contract and rules
web/oss/src/components/Layout/assets/styles.ts
StyleProps is redefined as MainStyleProps (removing footerHeight), content is changed from footer-height-dependent calculations to static height: "100%" and marginBottom: "2rem", and footer-related style keys (footer, footerLeft, footerLinkIcon) are removed.
Layout component refactoring
web/oss/src/components/Layout/Layout.tsx, web/oss/src/components/Layout/FooterIsland.tsx
Removed footer-specific imports and resize-observer plumbing, deleted the FooterIsland dynamic definition and the footer JSX block, removed footerHeight from AppWithVariants props and calls, and call sites now invoke useStyles without footerHeight. The FooterIsland export was removed.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix(frontend): remove copyright and social-links footer bar' accurately summarizes the primary change: removing a footer bar component with social links and copyright text.
Description check ✅ Passed The description is directly related to the changeset, providing clear context about why the footer was removed, what components were deleted, and how the related infrastructure was cleaned up.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/remove-footer-bar

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: db633bed-fcd0-4e88-b577-cf7fcdfce86e

📥 Commits

Reviewing files that changed from the base of the PR and between 98b8a9d and b5d2676.

📒 Files selected for processing (3)
  • web/oss/src/components/Layout/FooterIsland.tsx
  • web/oss/src/components/Layout/Layout.tsx
  • web/oss/src/components/Layout/assets/styles.ts
💤 Files with no reviewable changes (1)
  • web/oss/src/components/Layout/FooterIsland.tsx

Comment thread web/oss/src/components/Layout/Layout.tsx Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2026

Railway Preview Environment

Status Destroyed (PR closed)

Updated at 2026-06-05T10:11:27.368Z

@mmabrouk mmabrouk requested a review from ardaerzin June 5, 2026 09:16
The useStyles call cast its arg to StyleProps, but StyleProps was never
imported in Layout.tsx (a latent issue, flagged by review). With footerHeight
gone, StyleProps is just {themeMode}, so the cast is unnecessary. Pass the
arg directly; tsc confirms it type-checks.
@bekossy bekossy changed the base branch from main to release/v0.102.0 June 5, 2026 10:05
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jun 5, 2026
@bekossy bekossy merged commit f91b707 into release/v0.102.0 Jun 5, 2026
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Frontend lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants