Add encrypted plugin settings support#8
Merged
Merged
Conversation
Introduce AES-256-GCM encryption for sensitive plugin settings. Changes: - Add PLUGIN_SETTINGS_ENCRYPTION_KEY to .env.example and instruct how to generate it. - New engine/plugin-settings-crypto.ts with encrypt/decrypt helpers (format: enc:<iv>:<authTag>:<ciphertext>) and runtime validation of the key. - PluginManager and InstalledPluginsService now detect manifest setting definitions with encrypted: true and encrypt values on save. - InstalledPluginsService.getSettingsForContext added to return decrypted settings for plugin runtime, with graceful fallback on decryption errors. - SDK types updated to include encrypted?: true in plugin setting definitions. Why: Protect sensitive configuration (API keys, secrets) stored in plugin settings while allowing gradual migration of existing plaintext values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce AES-256-GCM encryption for sensitive plugin settings.
Changes:
Why: Protect sensitive configuration (API keys, secrets) stored in plugin settings while allowing gradual migration of existing plaintext values.