refactor: simplify macOS Seatbelt sandbox from whitelists to blanket allows#70
Merged
yishuiliunian merged 1 commit intomainfrom Apr 3, 2026
Merged
Conversation
…allows The sandbox repeatedly broke legitimate tools (Bazel TSan dylib, JVM, Nix toolchains) because sysctl-read, mach-lookup, iokit-open, and file-map-executable used per-item whitelists that could never cover every tool. Since process-exec/process-fork are already unrestricted, these whitelists add no security value — an attacker can exec() any static binary to bypass them. Replace with blanket (allow ...) for all four categories while keeping the real security boundaries tight: file-write* workspace containment, sensitive-file deny patterns, env-var sanitization, sysctl-write lock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sysctl-read,mach-lookup,iokit-open, andfile-map-executablewith blanket(allow ...)rulesprocess-exec/process-forkare already unrestricted, but repeatedly broke legitimate tools (Bazel TSan dylib, JVM crashes, Nix toolchains, etc.)file-write*workspace containment, sensitive-file deny patterns, env-var sanitization,sysctl-writelockChanges
crates/loopal-sandbox/src/platform/seatbelt_base.sbpl— major simplification (-62 lines of whitelists)crates/loopal-sandbox/src/platform/macos.rs— update doc commentcrates/loopal-sandbox/tests/suite/platform_macos_test.rs— replace whitelist assertions with blanket-allow assertionsTest plan
bazel test //crates/loopal-sandbox:loopal-sandbox_testpassesbazel build //... --config=clippypasses (0 warnings)bazel test //...passes (48/48 tests)