feat: add table cell borders and centralize markdown styles#71
Merged
yishuiliunian merged 2 commits intomainfrom Apr 3, 2026
Merged
feat: add table cell borders and centralize markdown styles#71yishuiliunian merged 2 commits intomainfrom
yishuiliunian merged 2 commits intomainfrom
Conversation
Add full box-drawing borders (┌┬┐ ├┼┤ └┴┘ │) to markdown table rendering for cleaner visual presentation. Centralize all hardcoded styles from writer_inline.rs and writer_table.rs into MarkdownStyles — link_url, image_marker, task_checked/unchecked, footnote_ref, table_border, table_header now have dedicated fields instead of inline Color/Modifier literals. Extract non-table tests (task list, link, image, footnote) from markdown_table_test.rs into markdown_elements_test.rs to respect the 200-line file limit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
┌┬┐├┼┤└┴┘│) to markdown table renderingMarkdownStyles— 7 new fields (link_url,image_marker,task_checked,task_unchecked,footnote_ref,table_border,table_header)markdown_elements_test.rs(200-line limit compliance)Changes
styles.rs— 7 new style fields with defaultswriter_table.rs— border rendering viaborder_line(), styles injected as paramswriter_inline.rs— replace 5 hardcodedColor::DarkGray/Color::Greenwithself.styles.*markdown_table_test.rs— border assertions, non-table tests extractedmarkdown_elements_test.rs— new file for task list, link, image, footnote testssuite.rs— register new test moduleTest plan
bazel test //crates/loopal-tui:loopal-tui_testpassesbazel build //crates/loopal-tui/... --config=clippyzero warnings