[16.0][IMP] purchase_request_kmitl: merge l10n_th_gov_purchase_request module#623
Open
madara1150 wants to merge 6 commits into16.0from
Open
[16.0][IMP] purchase_request_kmitl: merge l10n_th_gov_purchase_request module#623madara1150 wants to merge 6 commits into16.0from
madara1150 wants to merge 6 commits into16.0from
Conversation
Consolidate l10n_th_gov_purchase_request into purchase_request_kmitl to reduce module count and simplify dependencies. - Move all models (purchase.type, procurement.type, procurement.method, procurement.committee) into purchase_request_kmitl - Merge purchase.request and purchase.request.line extensions - Move all views, data, security, and wizard files - Update all 10 dependent modules to depend on purchase_request_kmitl - Add missing README.rst files for affected modules - Remove l10n_th_gov_purchase_request module
…e_request_payment_type
…eptance_kmitl Breaks 5-module circular dependency cycle introduced by the l10n_th_gov_purchase_request merge: purchase_request_kmitl → purchase_order_kmitl → purchase_invoice_plan_kmitl → purchase_contract_kmitl → purchase_work_acceptance_kmitl → purchase_request_kmitl purchase_contract_kmitl does not use anything from purchase_work_acceptance_kmitl in its models, views, or data.
models/__init__.py and wizards/__init__.py were emptied by pre-commit hooks during the merge commit. Restore all model and wizard imports so that procurement.type, procurement.method, purchase.type, and procurement.committee models are properly registered.
procurement_plan_id is defined in purchase_request_budget_procurement, not in purchase_request_budget. Use getattr to avoid AttributeError when the field is not yet available during module loading.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
l10n_th_gov_purchase_requestรวมเข้ากับpurchase_request_kmitlเพื่อลด module count และลด dependency ที่ซ้ำซ้อนpurchase.type,procurement.type,procurement.method,procurement.committee) เข้าpurchase_request_kmitlpurchase_request_kmitlแทนREADME.rststub ให้ modules ที่ยังไม่มีModules affected
l10n_th_gov_purchase_requestpurchase_request_kmitl)purchase_request_kmitlprocurement_method_no_securityprocurement_type_no_securitypurchase_request_approvalpurchase_request_approval_kmitlpurchase_request_budgetpurchase_request_egppurchase_request_payment_typepurchase_request_ux_kmitlpurchase_work_acceptance_kmitlagx_constructionkmitl_demoTest plan
purchase_request_kmitlและ dependent modules แล้ว upgrade สำเร็จl10n_th_gov_purchase_requestถูกลบออกจาก installed modules แล้ว