Skip to content

143 optimization#144

Merged
raymondwjang merged 47 commits into
mainfrom
143-optimization
Oct 21, 2025
Merged

143 optimization#144
raymondwjang merged 47 commits into
mainfrom
143-optimization

Conversation

@raymondwjang
Copy link
Copy Markdown
Member

@raymondwjang raymondwjang commented Oct 9, 2025

🔍 Type of Change

optimization getting out of hand, so splitting these into separate PRs.

  1. asset validation is expensive as hell. make it optional.
  2. residual only grabs the latest frame
  3. residual goes to zero in the new component area
    4. residual uses buffer (double-circular)
  4. change dim / coord names to make indexing with only dim possible
  5. optimize footprint update to use scipy sparse
  6. optimize trace update to use numpy
  7. remove boundary expansion from footprint update
  8. optimize overlaps update to use scipy operations
  9. optimize negative residual fit to use scipy operations
  10. optimize unlayered footprint search to use nonzero coords
  11. catalog - handle tiny shapes that weren't merged (remove them)
    13. residual learns instead of one-shot flooring to prevent outlier pixels from messing up the whole trace
  12. toy shapes asymmetric

🧪 Improvement: Enhancements or optimizations to existing code

📝 Description

🧪 Testing

  • Unit tests
  • Integration tests
  • Existing tests update

🛠️ Dependencies

✅ Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

📚 Documentation preview 📚: https://cala--144.org.readthedocs.build/en/144/

@raymondwjang raymondwjang linked an issue Oct 9, 2025 that may be closed by this pull request
@raymondwjang raymondwjang self-assigned this Oct 9, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 21, 2025

Codecov Report

❌ Patch coverage is 95.75758% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.47%. Comparing base (f13a859) to head (1f668f3).
⚠️ Report is 741 commits behind head on main.

Files with missing lines Patch % Lines
src/cala/nodes/traces.py 84.84% 5 Missing ⚠️
src/cala/assets.py 93.33% 4 Missing ⚠️
src/cala/nodes/footprints.py 91.66% 3 Missing ⚠️
src/cala/main.py 0.00% 1 Missing ⚠️
src/cala/nodes/overlap.py 94.11% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #144       +/-   ##
===========================================
- Coverage   86.60%   72.47%   -14.14%     
===========================================
  Files          56       44       -12     
  Lines        1769     2205      +436     
===========================================
+ Hits         1532     1598       +66     
- Misses        237      607      +370     
Flag Coverage Δ
unittests 72.47% <95.75%> (-14.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@raymondwjang raymondwjang merged commit 02da697 into main Oct 21, 2025
14 of 15 checks passed
@raymondwjang raymondwjang deleted the 143-optimization branch October 21, 2025 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optimization

1 participant