🎨 Palette: Improve screen reader accessibility for Search input watermark#289
Conversation
…atermark
Removed the empty `AutomationProperties.Name=""` attribute from the `TextBlock` watermark overlay on the main Search input in `SearchControl.xaml`. Setting this to an empty string improperly hides the helpful placeholder text ("Search (e.g., 'UserService', '/t', or '#')") from screen readers. By omitting the property, screen readers will now naturally fall back to reading the `Text` property, providing vital guidance and example inputs to users relying on assistive technologies.
Co-authored-by: AhmmedSamier <17784876+AhmmedSamier@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughReformatting and whitespace-only edits in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
💡 What: Removed
AutomationProperties.Name=""from the Search input's watermarkTextBlock.🎯 Why: Explicitly setting the accessibility name to an empty string on a watermark element is an anti-pattern that hides its text content. The
TextBlockcontains valuable example input formats ("Search (e.g., 'UserService', '/t', or '#')") that are not duplicated in theTextBox's tooltip. Removing the empty override ensures screen readers will read this text when the user tabs into the empty search box, significantly improving discoverability of search features for visually impaired users.♿ Accessibility: Improved screen reader announcements for the primary search input by exposing missing instructional text.
PR created automatically by Jules for task 7566975797142854191 started by @AhmmedSamier
Summary by CodeRabbit