⚡ Bolt: [O(N) Callback Removal]

[AhmmedSamier]

💡 What

Replaced Array.prototype.filter() with a traditional for loop and .push() in the performSymbolSearch method of SearchEngine for the OPEN and MODIFIED scopes.

🎯 Why

In performance-critical hot paths, chaining or using array higher-order functions like .filter() creates unnecessary overhead by allocating and executing a callback function for every element in the array. Converting this to a manual loop with .push() avoids this overhead while preserving readability. Additionally, it adds defensive fallback logic (|| []) to prevent potential TypeError if undefined arrays are returned.

📊 Impact

Reduces object/callback allocations during symbol search execution in OPEN and MODIFIED scopes, leading to marginally faster filtering and less garbage collection pressure when dealing with large volumes of indexed symbols.

🔬 Measurement

Run bun test in language-server to verify the search functions continue to operate flawlessly. No regressions in the standard unit tests.

---

PR created automatically by Jules for task 14325502709934521306 started by @AhmmedSamier

Summary by CodeRabbit

• Refactor
  • Optimized symbol search filtering to improve performance.

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5c139751-3f43-48a1-a6d3-3fd564986101

📥 Commits

Reviewing files that changed from the base of the PR and between e8b97d4 and 54838c1.

📒 Files selected for processing (1)

• language-server/src/core/search-engine.ts

---

📝 Walkthrough

Walkthrough

The PR refactors performSymbolSearch in the search engine to replace Array.prototype.filter() calls with manual for loops when processing OPEN and MODIFIED search scopes, filtering out SearchItemType.FILE entries while maintaining the same control flow.

Changes

Cohort / File(s)	Summary
Search Engine Loop Refactoring language-server/src/core/search-engine.ts	Replaced filter-based removal of FILE type entries in SearchScope.OPEN and SearchScope.MODIFIED branches with explicit for loop constructs that conditionally push non-FILE indices, adding || [] fallback handling for raw index arrays.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

• ⚡ Bolt: optimize array allocations and string parsing in indexer paths #306: Modifies the same search-engine file to replace intermediate array allocations with explicit loops using identical code patterns.
• ⚡ Bolt: optimize handleEmptyQuerySearch with single-pass filtering #333: Refactors search-engine.ts with similar in-loop filtering for OPEN/MODIFIED scopes in the SearchEngine class.
• ⚡ Bolt: O(1) Open File Filtering #262: Touches the same function flow by optimizing getIndicesForOpenFiles reverse-index handling, complementing this PR's index consumption changes.

Poem

🐰 Filter away, oh loops so grand,
Manual indexing now takes command,
FILE types filtered by hand-written loops,
No heap allocations in our troops—
Faster searches hop through the land! 🚀

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title mentions 'O(N) Callback Removal' which aligns with the changeset that replaces Array.prototype.filter() callbacks with a manual for loop to eliminate callback allocation overhead.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch bolt-search-engine-filter-optimization-14325502709934521306

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}