fix: handle symlink loops causing RuntimeError in Path.resolve()#5223
Open
Sarthak816 wants to merge 1 commit into
Open
fix: handle symlink loops causing RuntimeError in Path.resolve()#5223Sarthak816 wants to merge 1 commit into
Sarthak816 wants to merge 1 commit into
Conversation
When resolving paths with Path.resolve(), symlink loops raise RuntimeError on Python 3.12+.\n\nThis fix ensures safe_abs_path() catches RuntimeError alongside OSError, and\nupdates other raw .resolve() calls in base_coder.py and repo.py to use the same\nsafe pattern.\n\nCloses Aider-AI#5146
Sarthak816
force-pushed
the
fix/5146-symlink-loop-runtime-error
branch
from
76593d1 to
85997f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When resolving paths with Path.resolve(), symlink loops raise RuntimeError on Python 3.12+ and crash aider.
This fix ensures safe_abs_path() catches RuntimeError alongside OSError, and
updates other raw .resolve() calls in base_coder.py and repo.py to use the same
safe pattern.
Closes #5146