Skip to content

Fix SSRF bug: Ignore case when comparing hostnames #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bitterpanda63 merged 3 commits into from
Jul 11, 2025
Merged

Fix SSRF bug: Ignore case when comparing hostnames #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f8c0184
findHostnameInUserInput use equalsIgnoreCase
bitterpanda63 Jul 9, 2025
a56f90c
Add unit test that checks equalsIgnoreCase is in use
bitterpanda63 Jul 9, 2025
d29479f
Add unit tests to the function hostnameInUserInput for equalsIgnoreCase
bitterpanda63 Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion agent_api/src/main/java/dev/aikido/agent_api/vulnerabilities/ssrf/FindHostnameInContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public static boolean hostnameInUserInput(String userInput, String hostname, int
if (userInputUrl == null || userInputUrl.getHost() == null) {
continue;
}
if (userInputUrl.getHost().equals(hostnameUrl.getHost())) {
if (userInputUrl.getHost().equalsIgnoreCase(hostnameUrl.getHost())) {
if (userInputUrl.getPort() == -1 || port == -1) {
return true;
}
Expand Down
11 changes: 11 additions & 0 deletions agent_api/src/test/java/vulnerabilities/ssrf/FindHostnameInContextTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,17 @@ void testItParsesHostnameFromUserInputWithPathBehindIt() {
assertTrue(hostnameInUserInput("http://localhost/path", "localhost", 80));
}

@Test
void testHostnameCapitalizationIsNotImportant() {
assertTrue(hostnameInUserInput("http://Localhost/path", "localhost", 80));
}

@Test
void testHostnameCapitalizationIsNotImportant2() {
assertTrue(hostnameInUserInput("http://localhost/path", "LOCALHOST", 80));
}


@Test
void testItDoesNotParseHostnameFromUserInputWithMisspelledProtocol() {
assertFalse(hostnameInUserInput("http:/localhost", "localhost", 80));
Expand Down
24 changes: 24 additions & 0 deletions agent_api/src/test/java/vulnerabilities/ssrf/SSRFDetectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,30 @@ public void testSsrfDetectorWithRedirectTo127IP() throws MalformedURLException {
assertEquals("8080", attackData.metadata.get("port"));
}

@Test
@SetEnvironmentVariable(key = "AIKIDO_TOKEN", value = "invalid-token")
public void testSsrfDetectorWithRedirectTo127IPButHostnameCapitalizationDifferent() throws MalformedURLException {
// Setup context :
setContextAndLifecycle("http://Ssrf-redirects.testssandbox.com/ssrf-test");

URLCollector.report(new URL("http://Ssrf-redirects.testssandbox.com/ssrf-test"));
RedirectCollector.report(new URL("http://ssrf-Redirects.testssandbox.com/ssrf-test"), new URL("http://127.0.0.1:8080"));
Attack attackData = new SSRFDetector().run(
"127.0.0.1", 8080,
List.of("127.0.0.1"),
"testop"
);

assertNotNull(attackData);
assertEquals("testop", attackData.operation);
assertEquals("ssrf", attackData.kind);
assertEquals("query", attackData.source);
assertEquals("http://Ssrf-redirects.testssandbox.com/ssrf-test", attackData.payload);
assertEquals(".arg.[0]", attackData.pathToPayload);
assertEquals("127.0.0.1", attackData.metadata.get("hostname"));
assertEquals("8080", attackData.metadata.get("port"));
}

@Test
@SetEnvironmentVariable(key = "AIKIDO_TOKEN", value = "invalid-token")
public void testSsrfDetectorWithRedirectToLocalhost() throws MalformedURLException {
Expand Down