fix: move prototype pollution guards inline for CodeQL taint analysis#3
Merged
anshultibby-at merged 2 commits intomainfrom Mar 26, 2026
Merged
Conversation
CodeQL's taint tracking does not recognise the batch Array.some() guard as protecting the downstream assignments. Moving the DANGEROUS_KEYS check immediately before each key-based write (inside the loop and before the final assignment) makes the guard visible to CodeQL's per-usage analysis, resolving alerts #2 and #3. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
CodeQL's sanitizer recognition for js/prototype-polluting-assignment requires direct equality checks (=== '__proto__', etc.) immediately before the computed property assignment. It does not recognise Set.has() as an equivalent sanitizer, so the alerts remained open. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeQL's taint tracking does not recognise the batch Array.some() guard as protecting the downstream assignments. Moving the DANGEROUS_KEYS check immediately before each key-based write (inside the loop and before the final assignment) makes the guard visible to CodeQL's per-usage analysis, resolving alerts #2 and #3.