Conversation
Added a DOI link to the citation in README.md
- `pip install longhap` then `longhap --version` was working, but `./longhap.py --version` was failing because it was expecting a package and using importlib - fix is using __version__ in longhap.py and dynamic version in the pyproject.toml - added tests in GHA which now runs on pushes to main and dev but only releases to pypi on release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously specified version in the pyproject.toml which worked for
pip install longhapand thenlonghap --versionbut not for./longhap.py --versionbecause we were using importlib.Now we specify
__version__in longhap.py and pyproject.toml version dynamically fetches it.Updated github actions to build and run longhap as a package and as a script in a conda env on pushed to main and dev, but to only release to pypi on releases