added docker file for mcp#1
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a Dockerfile to containerize an MCP server using Kali Linux as the base image, installing several security/penetration testing tools.
Changes:
- Adds a new Dockerfile based on
kali-rollingwith penetration testing tools installed
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,13 @@ | |||
|
|
|||
There was a problem hiding this comment.
The first line is blank, which is unnecessary and non-standard for Dockerfiles. The FROM instruction should be the first line of the file.
| @@ -0,0 +1,13 @@ | |||
|
|
|||
| FROM kalilinux/kali-rolling | |||
There was a problem hiding this comment.
The base image kalilinux/kali-rolling is unpinned (no specific version tag or digest). This means builds are not reproducible and could break silently when the rolling release updates. Consider pinning to a specific digest or a dated snapshot tag, e.g., kalilinux/kali-rolling@sha256:<digest>.
| FROM kalilinux/kali-rolling | |
| FROM kalilinux/kali-rolling@sha256:1111111111111111111111111111111111111111111111111111111111111111 |
| @@ -0,0 +1,13 @@ | |||
|
|
|||
| FROM kalilinux/kali-rolling | |||
There was a problem hiding this comment.
Using Kali Linux as a base image bundles a large attack surface with many pre-existing tools and libraries. If the intent is only to run the MCP server with a few utilities, consider using a minimal base image (e.g., debian:slim or ubuntu:22.04) and installing only the required packages. This reduces the image size and potential vulnerability exposure.
| FROM kalilinux/kali-rolling | |
| FROM debian:stable-slim |
No description provided.