Log errors in CoapClient.tryToConnect()#30
Merged
AlCalzone merged 1 commit intoAlCalzone:masterfrom Feb 13, 2018
Merged
Conversation
I'm trying to use a library which uses this library (node-tradfri-client), where I've managed to find out that the attempts to establish a connection fail in this method. This commits adds a debug call to attempt to give the user some context as to why the attempt to establish a connection fails.
Contributor
Author
|
After working around the problem I learned that the problem was that I had upper case characters in the hostname. We might want to consider any of the following:
|
Owner
|
Thanks! I'm not sure what you mean with your 3rd proposal, can you elaborate please? |
AlCalzone
added a commit
that referenced
this pull request
Feb 13, 2018
* test DeferredPromise * build the change from #30
Owner
|
Oh I think I understand. The given resource URL gets parsed by the |
AlCalzone
added a commit
that referenced
this pull request
Feb 13, 2018
…en to `tryToConnect` (fixes the issue mentioned in #30) * added tests for `getConnection`
Owner
|
Should be fixed in v0.5.4, please test! |
Contributor
Author
|
I haven't had the chance to test this but looking at the code it looks like it should solve it completely 👌 Thanks for the quick feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm trying to use a library which uses this library (node-tradfri-client), where I've managed to find out that the attempts to establish a connection fail in this method. This commits adds a debug call to attempt to give the user some context as to why the attempt to establish a connection fails.