SUM(FUNC(x)) is BROKEN since 2.2.0

[phantasma2983]

Tested SUM(FLOOR(col) and it is not running FLOOR or CEIL or ROUND or anything inside SUM ever since version 2.2.0 release.
It's working fine in 2.1.8 all versions after that are not working for this use-case.

[mathiasrw]

omg. I dont know how I missed this issue! - this is huge!

Thank you for letting us know!!!

[Shibn2]

If the issue is still not fixed, I 'd like to contribute @mathiasrw

[NmN03jain]

in this issue we have to make changes every place where sum is used ?

[mathiasrw]

I am not sure. I have not looked into it.

[rrameshkumar76]

@mathiasrw I took a quick look at this (https://github.com/rrameshkumar76/alasql/pull/1/files?diff=unified&w=1) , Have an slight idea for a fix based on my limited understanding. I am having issue with one test using tables and spy(https://github.com/AlaSQL/alasql/blob/develop/test/test020.js#L67).

I am little unclear with this https://github.com/AlaSQL/alasql/blob/develop/test/test020.js#L53C3-L53C30 used in spec when the spy function is expected to be used or not in the various test criteria used in that test. I have changed those tests based on my understanding of whats correct.

I will have to add a much better tests also.

I also think some fix has to be done for MIN, MAX etc also afaict. I am trying those also in above,

[mathiasrw]

when the spy function is expected to be used or not

The spy function is just a random name for a custom function. Maybe I did not understand your doubt. Please ask again so we can progress together.

[rrameshkumar76]

Thanks, yeah thats what I thought too on the name spy was not anything special. I forgot to properly edit my comments above. Sorry about that.

I will create a PR for above