Fix replace function #2282
Merged
Fix replace function #2282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@copilot Can you please confirm these changes are implemented, and verify we got this sorted right and nice and tidy? 
|
Contributor
|
@mathiasrw I've opened a new pull request, #2283, to work on those changes. Once the pull request is ready, I'll request review from you. |
Member
Author
|
@copilot Please have a look and make sure we did not break anything, that we can do yarn format and that yarn test is running smoothly. |
Contributor
|
@mathiasrw I've opened a new pull request, #2285, to work on those changes. Once the pull request is ready, I'll request review from you. |
…ests Co-authored-by: mathiasrw <1063454+mathiasrw@users.noreply.github.com>
Co-authored-by: mathiasrw <1063454+mathiasrw@users.noreply.github.com>
Fix REPLACE function to handle numeric inputs like MySQL/SQLite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for the time you are putting into AlaSQL!
#1455