Skip to content

style(SAPEREGradient): simplify gradient processing and enhance readability #5313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DanySK merged 2 commits into from
Apr 28, 2026
Merged

style(SAPEREGradient): simplify gradient processing and enhance readability #5313

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90a7952
style(SAPEREGradient): simplify gradient processing and enhance reada…
DanySK Apr 28, 2026
94d9a0b
Update alchemist-incarnation-sapere/src/main/java/it/unibo/alchemist/…
DanySK Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
136 changes: 77 additions & 59 deletions ...nation-sapere/src/main/java/it/unibo/alchemist/model/sapere/reactions/SAPEREGradient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,70 +467,88 @@ private class GradientSearch implements TIntObjectProcedure<List<? extends ILsaM

@Override
public boolean execute(final int a, final List<? extends ILsaMolecule> mgnList) {
if (!mgnList.isEmpty()) {
final P aPos = positionCache.get(a);
final double distNode = aPos.distanceTo(mypos);
matches.put(LsaMolecule.SYN_O, new NumTreeNode(a));
matches.put(LsaMolecule.SYN_D, new NumTreeNode(distNode));
if (mapenvironment != null) {
matches.put(LsaMolecule.SYN_ROUTE, new NumTreeNode(routecache.get(a)));
}
final Map<HashString, ITreeNode<?>> localMatches = mgnList.size() > 1 ? new HashMap<>(matches) : matches;
for (final ILsaMolecule mgn : mgnList) {
/*
* Instance all the variables but synthetics.
*/
for (int i = 0; i < gradient.size(); i++) {
final ITreeNode<?> uninstancedArg = gradient.getArg(i).getRootNode();
if (uninstancedArg.getType().equals(Type.VAR)) {
final HashString varName = uninstancedArg.toHashString();
if (!varName.toString().startsWith("#")) {
final ITreeNode<?> localVal = mgn.getArg(i).getRootNode();
localMatches.put(varName, localVal);
}
}
}
/*
* Compute new value
*/
final List<IExpression> valuesFound = gradientExpr.allocateVar(localMatches);
if (gradientsFound.isEmpty()) {
if ((Double) valuesFound.get(argPosition).getRootNodeData() <= threshold) {
gradientsFound.add(new LsaMolecule(valuesFound));
}
} else {
boolean compatibleFound = false;
for (int j = 0; j < gradientsFound.size(); j++) {
final ILsaMolecule gradToCompare = gradientsFound.get(j);
int i = 0;
for (; i < argPosition; i++) {
if (!gradToCompare.getArg(i).matches(valuesFound.get(i), null)) {
/*
* Gradients are not compatible
*/
break;
}
}
if (i == argPosition) {
/*
* These two gradients are comparable
*/
compatibleFound = true;
final double newVal = (Double) valuesFound.get(argPosition).getRootNodeData();
final double oldVal = (Double) gradToCompare.getArg(argPosition).getRootNodeData();
if (newVal < oldVal) {
gradientsFound.set(j, new LsaMolecule(valuesFound));
}
}
}
if (!compatibleFound && (Double) valuesFound.get(argPosition).getRootNodeData() < threshold) {
gradientsFound.add(new LsaMolecule(valuesFound));
}
if (mgnList.isEmpty()) {
return true;
}
final Map<HashString, ITreeNode<?>> localMatches = prepareMatches(a, mgnList.size());
for (final ILsaMolecule mgn : mgnList) {
bindGradientVariables(mgn, localMatches);
updateGradientsFound(gradientExpr.allocateVar(localMatches));
}
return true;
}

private void bindGradientVariables(
final ILsaMolecule molecule,
final Map<HashString, ITreeNode<?>> localMatches
) {
for (int i = 0; i < gradient.size(); i++) {
final ITreeNode<?> uninstancedArg = gradient.getArg(i).getRootNode();
if (uninstancedArg.getType().equals(Type.VAR)) {
final HashString varName = uninstancedArg.toHashString();
if (!varName.toString().startsWith("#")) {
localMatches.put(varName, molecule.getArg(i).getRootNode());
}
}
}
}

private boolean isCompatibleGradient(final ILsaMolecule gradientToCompare, final List<IExpression> valuesFound) {
for (int i = 0; i < argPosition; i++) {
if (!gradientToCompare.getArg(i).matches(valuesFound.get(i), null)) {
return false;
}
}
return true;
}

private boolean isWithinThreshold(final List<IExpression> valuesFound) {
return candidateDistance(valuesFound) <= threshold;
}

private double candidateDistance(final List<IExpression> valuesFound) {
return (Double) valuesFound.get(argPosition).getRootNodeData();
}

private Map<HashString, ITreeNode<?>> prepareMatches(final int nodeId, final int moleculeCount) {
final P nodePosition = positionCache.get(nodeId);
matches.put(LsaMolecule.SYN_O, new NumTreeNode(nodeId));
matches.put(LsaMolecule.SYN_D, new NumTreeNode(nodePosition.distanceTo(mypos)));
if (mapenvironment != null) {
matches.put(LsaMolecule.SYN_ROUTE, new NumTreeNode(routecache.get(nodeId)));
}
return moleculeCount > 1 ? new HashMap<>(matches) : matches;
}

private void updateGradientsFound(final List<IExpression> valuesFound) {
if (gradientsFound.isEmpty()) {
if (isWithinThreshold(valuesFound)) {
gradientsFound.add(new LsaMolecule(valuesFound));
}
return;
}
var compatibleGradientFound = false;
for (int i = 0; i < gradientsFound.size(); i++) {
final ILsaMolecule gradientToCompare = gradientsFound.get(i);
if (isCompatibleGradient(gradientToCompare, valuesFound)) {
compatibleGradientFound = true;
replaceWithBetterGradient(i, gradientToCompare, valuesFound);
}
}
if (!compatibleGradientFound && candidateDistance(valuesFound) < threshold) {
gradientsFound.add(new LsaMolecule(valuesFound));
}
}

private void replaceWithBetterGradient(
final int gradientIndex,
final ILsaMolecule currentGradient,
final List<IExpression> candidateGradient
) {
if (candidateDistance(candidateGradient) < (Double) currentGradient.getArg(argPosition).getRootNodeData()) {
gradientsFound.set(gradientIndex, new LsaMolecule(candidateGradient));
}
}
}

private static class SGFakeConditionAction implements Action<List<ILsaMolecule>>, Condition<List<ILsaMolecule>> {
Expand Down
Loading