test(incarnation-sapere): harden LsaNode concurrency test by DanySK · Pull Request #5325 · AlchemistSimulator/Alchemist

DanySK · 2026-04-29T21:03:25Z

No description provided.

Copilot

Pull request overview

This PR strengthens the SAPERE incarnation’s LsaNode concurrency test by explicitly tracking submitted tasks and waiting on their completion via Future#get, aiming to make concurrency failures more reliably detectable.

Changes:

Track submitted executor tasks via List<Future<?>> and wait for completion with a timeout.
Convert previously in-task exception handling into main-thread handling via Future#get.
Adjust writer-thread molecule naming used during concurrent modifications.

codecov · 2026-04-29T21:31:08Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.53%. Comparing base (249a798) to head (c78d86a).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##             master    #5325   +/-   ##
=========================================
  Coverage     61.53%   61.53%           
  Complexity       14       14           
=========================================
  Files             2        2           
  Lines            78       78           
  Branches          4        4           
=========================================
  Hits             48       48           
  Misses           24       24           
  Partials          6        6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

DanySK · 2026-04-30T07:25:22Z

@codex review

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

chatgpt-codex-connector · 2026-04-30T07:29:47Z

Codex Review: Didn't find any major issues. You're on a roll.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Copilot · 2026-04-30T09:30:18Z

+        } finally {
+            executor.shutdownNow();
+            try {
+                if (!executor.awaitTermination(TIMEOUT_SECONDS, TimeUnit.SECONDS)) {
+                    throw new AssertionError("Executor did not terminate within " + TIMEOUT_SECONDS + " seconds");
+                }
+            } catch (final InterruptedException e) {
+                Thread.currentThread().interrupt();
+                throw new AssertionError("Interrupted while waiting for executor termination", e);
+            }


The finally block can throw a new AssertionError if awaitTermination fails, which may mask an earlier failure from latch.await(...) or a task.get(...) exception (the original assertion/stack trace gets replaced). Consider capturing the primary failure, then performing shutdown/awaitTermination, and only throwing a termination error if there was no prior failure (or add it as a suppressed exception).

@copilot apply changes based on this feedback

Fixed in 534e3c4. The try block now has an outer catch (AssertionError e) that stores the primary failure. In the finally block, any termination error is added as a suppressed exception on primaryFailure (via addSuppressed) if one exists, so the original stack trace is always preserved. After finally, primaryFailure is rethrown if set.

…model/sapere/nodes/LsaNodeConcurrencyTest.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…List import, ensure executor shutdown in finally Agent-Logs-Url: https://github.com/AlchemistSimulator/Alchemist/sessions/6651c551-7d20-4a2c-aebc-a2f43f4054f8 Co-authored-by: DanySK <1991673+DanySK@users.noreply.github.com>

…xplicitly Agent-Logs-Url: https://github.com/AlchemistSimulator/Alchemist/sessions/6651c551-7d20-4a2c-aebc-a2f43f4054f8 Co-authored-by: DanySK <1991673+DanySK@users.noreply.github.com>

…model/sapere/nodes/LsaNodeConcurrencyTest.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…nation also fails If the try block (latch.await or task.get) throws an AssertionError, it is captured as primaryFailure. In the finally block, shutdownNow + awaitTermination runs unconditionally; any termination error is added as a suppressed exception on primaryFailure (preserving its stack trace) rather than replacing it. If there was no prior failure, the termination error is thrown directly as before. Agent-Logs-Url: https://github.com/AlchemistSimulator/Alchemist/sessions/5a82b660-ae48-43f3-a76d-95df9ff49832 Co-authored-by: DanySK <1991673+DanySK@users.noreply.github.com>

sonarqubecloud · 2026-05-01T08:02:11Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copilot AI review requested due to automatic review settings April 29, 2026 21:03

DanySK added the auto-update-rebase label Apr 29, 2026

DanySK enabled auto-merge (squash) April 29, 2026 21:03

Copilot started reviewing on behalf of DanySK April 29, 2026 21:04 View session

Copilot AI reviewed Apr 29, 2026

View reviewed changes

DanySK force-pushed the test/incarnation-sapere/hardenlsanodecon branch 6 times, most recently from 6690be6 to c78d86a Compare April 30, 2026 06:11

Copilot started work on behalf of DanySK April 30, 2026 07:06 View session

auto-merge was automatically disabled April 30, 2026 07:13
Head branch was pushed to by a user without write access

Copilot finished work on behalf of DanySK April 30, 2026 07:17

Copilot started work on behalf of DanySK April 30, 2026 07:17 View session

Copilot finished work on behalf of DanySK April 30, 2026 07:19

DanySK requested a review from Copilot April 30, 2026 07:25

Copilot started reviewing on behalf of DanySK April 30, 2026 07:25 View session

DanySK enabled auto-merge (squash) April 30, 2026 07:25

Copilot AI reviewed Apr 30, 2026

View reviewed changes

Comment thread ...ation-sapere/src/test/java/it/unibo/alchemist/model/sapere/nodes/LsaNodeConcurrencyTest.java

DanySK force-pushed the test/incarnation-sapere/hardenlsanodecon branch 2 times, most recently from 8c4b6f9 to 39cdeac Compare April 30, 2026 09:16

DanySK requested a review from Copilot April 30, 2026 09:27

Copilot started reviewing on behalf of DanySK April 30, 2026 09:28 View session

Copilot AI reviewed Apr 30, 2026

View reviewed changes

DanySK force-pushed the test/incarnation-sapere/hardenlsanodecon branch 2 times, most recently from 22643a8 to caa5285 Compare April 30, 2026 21:20

DanySK force-pushed the test/incarnation-sapere/hardenlsanodecon branch 3 times, most recently from 087bccb to 5e67efd Compare May 1, 2026 00:18

DanySK and others added 6 commits May 1, 2026 09:54

test(incarnation-sapere): harden LsaNode concurrency test

7bc9c78

Update alchemist-incarnation-sapere/src/test/java/it/unibo/alchemist/…

330ea2d

…model/sapere/nodes/LsaNodeConcurrencyTest.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update alchemist-incarnation-sapere/src/test/java/it/unibo/alchemist/…

464b368

…model/sapere/nodes/LsaNodeConcurrencyTest.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

test(incarnation-sapere): handle InterruptedException in task.get() e…

773f9a6

…xplicitly Agent-Logs-Url: https://github.com/AlchemistSimulator/Alchemist/sessions/6651c551-7d20-4a2c-aebc-a2f43f4054f8 Co-authored-by: DanySK <1991673+DanySK@users.noreply.github.com>

Update alchemist-incarnation-sapere/src/test/java/it/unibo/alchemist/…

c965fa7

…model/sapere/nodes/LsaNodeConcurrencyTest.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

DanySK force-pushed the test/incarnation-sapere/hardenlsanodecon branch from 5e67efd to c965fa7 Compare May 1, 2026 07:54

Copilot started work on behalf of DanySK May 1, 2026 07:54 View session

auto-merge was automatically disabled May 1, 2026 08:01
Head branch was pushed to by a user without write access

Copilot finished work on behalf of DanySK May 1, 2026 08:01

Conversation

DanySK commented Apr 29, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

DanySK commented Apr 30, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Apr 30, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

DanySK May 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 1, 2026

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented May 1, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov Bot commented Apr 29, 2026 •

edited

Loading