The sitemap.xml requires absolute URLs in <loc> tags#3753
Merged
tvdeyen merged 1 commit intoAlchemyCMS:mainfrom Mar 16, 2026
Merged
The sitemap.xml requires absolute URLs in <loc> tags#3753tvdeyen merged 1 commit intoAlchemyCMS:mainfrom
tvdeyen merged 1 commit intoAlchemyCMS:mainfrom
Conversation
…protocol. url_for with a string path returns the path as-is, so use request.base_url to prepend protocol and host.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3753 +/- ##
=======================================
Coverage 97.46% 97.46%
=======================================
Files 317 317
Lines 8431 8431
=======================================
Hits 8217 8217
Misses 214 214 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tvdeyen
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
show_alchemy_page_url was returning only a path (e.g. /) instead of an absolute URL (e.g. https://www.example.com/). The sitemap protocol requires absolute URLs in tags — relative paths cause the sitemap to be invalid.
The root cause: url_for with a string argument returns the string as-is in Rails and does not prepend protocol or host. Fixed by using request.base_url to build the absolute URL.
Notable changes (remove if none)
show_alchemy_page_url now correctly returns an absolute URL including protocol and host. Specs updated accordingly.
Checklist