refactor(image cropper): accept settings object instead of positional args#3754
Open
refactor(image cropper): accept settings object instead of positional args#3754
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3754 +/- ##
=======================================
Coverage 97.46% 97.46%
=======================================
Files 317 317
Lines 8431 8431
=======================================
Hits 8217 8217
Misses 214 214 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… args Replace the five positional constructor arguments with a single settings object. The ERB template now passes all cropper settings via a single .to_json call, resolving herb-lint erb-no-unsafe-script-interpolation warnings.
tvdeyen
force-pushed
the
refactor-image-cropper-settings-object
branch
from
e60e10d to
f15505c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Replace the five positional constructor arguments with a single
settingsobject. The ERB template now passes all cropper settings via a single.to_jsoncall, resolvingherb-linterb-no-unsafe-script-interpolationwarnings.Checklist