Skip to content

fix(alchemy-notice): Use default font size for headings#3833

Merged
tvdeyen merged 1 commit intomainfrom
fix/notice-heading-font-size
Apr 13, 2026
Merged

fix(alchemy-notice): Use default font size for headings#3833
tvdeyen merged 1 commit intomainfrom
fix/notice-heading-font-size

Conversation

@tvdeyen
Copy link
Copy Markdown
Member

@tvdeyen tvdeyen commented Apr 13, 2026

What is this pull request for?

We do not want to mix font-sizes in notices. H1 was already resetted. H2 and H3 were missing.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

@tvdeyen tvdeyen requested a review from a team as a code owner April 13, 2026 09:31
@tvdeyen tvdeyen added backport-to-8.0-stable Needs to be backported to 8.0-stable backport-to-8.1-stable Needs to be backported to 8.1-stable backport-to-8.2-stable Needs to be backported to 8.2-stable labels Apr 13, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.06%. Comparing base (53eecba) to head (c4b34ab).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3833   +/-   ##
=======================================
  Coverage   98.06%   98.06%           
=======================================
  Files         322      322           
  Lines        8526     8526           
=======================================
  Hits         8361     8361           
  Misses        165      165           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

We do not want to mix font-sizes in notices. H1 was already
resetted. H2 and H3 were missing.
@tvdeyen tvdeyen force-pushed the fix/notice-heading-font-size branch from 0951a0a to c4b34ab Compare April 13, 2026 10:29
@tvdeyen tvdeyen enabled auto-merge April 13, 2026 10:29
@tvdeyen tvdeyen merged commit 483c23c into main Apr 13, 2026
27 of 28 checks passed
@tvdeyen tvdeyen deleted the fix/notice-heading-font-size branch April 13, 2026 10:37
@alchemycms-bot
Copy link
Copy Markdown

💔 Some backports could not be created

Status Branch Result
8.0-stable Backport failed because of merge conflicts
8.1-stable Backport failed because of merge conflicts
8.2-stable

Manual backport

To create the backport manually run:

backport --pr 3833

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-to-8.0-stable Needs to be backported to 8.0-stable backport-to-8.1-stable Needs to be backported to 8.1-stable backport-to-8.2-stable Needs to be backported to 8.2-stable

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants