Skip to content

feat: Conditional dashboard widgets#3915

Merged
tvdeyen merged 1 commit into
mainfrom
conditional-widgets
May 28, 2026
Merged

feat: Conditional dashboard widgets#3915
tvdeyen merged 1 commit into
mainfrom
conditional-widgets

Conversation

@tvdeyen
Copy link
Copy Markdown
Member

@tvdeyen tvdeyen commented May 27, 2026

What is this pull request for?

Instead of having the condition outside of the widget callside, we pass a lambda to the widget as condition argument and exec it in the widgets instance. That way we can lazy evaluate the condition and store instances of widgets in the future in order to make them configurable outside of the view context.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

@tvdeyen tvdeyen requested a review from a team as a code owner May 27, 2026 21:13
@tvdeyen tvdeyen added the enhancement New feature or enhancement label May 27, 2026
@tvdeyen tvdeyen added this to the 8.3 milestone May 27, 2026
@tvdeyen tvdeyen enabled auto-merge May 27, 2026 21:14
@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.15%. Comparing base (0a14c91) to head (7c4ee2b).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3915   +/-   ##
=======================================
  Coverage   98.15%   98.15%           
=======================================
  Files         343      343           
  Lines        8868     8874    +6     
=======================================
+ Hits         8704     8710    +6     
  Misses        164      164           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tvdeyen tvdeyen force-pushed the conditional-widgets branch 4 times, most recently from 17f5877 to 55536e1 Compare May 28, 2026 09:03
Instead of having the condition outside of the widget callside,
we pass a lambda to the widget as condition argument and exec
it in the widgets instance. That way we can lazy evaluate the
condition and store instances of widgets in the future in order
to make them configurable outside of the view context.
@tvdeyen tvdeyen force-pushed the conditional-widgets branch 2 times, most recently from 81aa24a to 7c4ee2b Compare May 28, 2026 10:26
@tvdeyen tvdeyen merged commit 075cc66 into main May 28, 2026
27 of 28 checks passed
@tvdeyen tvdeyen deleted the conditional-widgets branch May 28, 2026 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants