Closed
Conversation
yurii-litvinov
suggested changes
Jan 1, 2025
yurii-litvinov
left a comment
yurii-litvinov
left a comment
There was a problem hiding this comment.
Какой-то хаос в репозитории, стоит навести порядок ASAP
| const char* value; | ||
| } NodeValue; | ||
|
|
||
| typedef struct Node { |
There was a problem hiding this comment.
Можно было NodeValue сделать просто typedef-ом на char*
| NodeValue value; | ||
| struct Node* leftChild; | ||
| struct Node* rightChild; | ||
| } Node; |
There was a problem hiding this comment.
Кстати, определений структур не надо в .h
|
|
||
| Node* createNode(NodeValue *value) { | ||
| Node* node = calloc(1, sizeof(Node)); | ||
| node->value = *value; |
|
|
||
| skipWhitespaceAndBrackets(string, indexOfString); | ||
|
|
||
| if (isdigit(string[*indexOfString])) { |
There was a problem hiding this comment.
Так может быть плохо с отрицательными числами
| if (string[*indexOfString] == '+' || string[*indexOfString] == '-' || string[*indexOfString] == '*' || string[*indexOfString] == '/') { | ||
| char operationToCount = string[*indexOfString]; | ||
| Node* node = createNode(operationToCount); | ||
| indexOfString++; |
There was a problem hiding this comment.
Это инкремент указателя, а не значения, так что должно было страшно падать при обращении к нему ниже :)
| struct Node* rightChild; | ||
| } Node; | ||
|
|
||
| NodeValue createValue(const char* value); |
| bool testCreateNode() { | ||
| NodeValue value = createValue("1"); | ||
| Node* node = createNode(value); | ||
| return (strcmp(node->value.value, "1") == 0 && node->leftChild == NULL && node->rightChild == NULL); |
| return number; | ||
| } | ||
|
|
||
| Node* modifyString(const char* string, int* indexOfString) { |
There was a problem hiding this comment.
Почему функция, строящая дерево разбора по строке, называется так странно? Она даже никак не модифицирует строку :)
| } | ||
|
|
||
| bool allTests() { | ||
| return (testCreateNode && testCalculation && testTreeBuilding); |
There was a problem hiding this comment.
Тесты не вызываются, поэтому и не падает, хотя должно
| #include "Tests.h" | ||
|
|
||
| int main(void) { | ||
| if (!allTests) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.