Skip to content

Fix #79#86

Merged
mys007 merged 1 commit intomainfrom
fix-additional-artifact-references
Oct 7, 2025
Merged

Fix #79#86
mys007 merged 1 commit intomainfrom
fix-additional-artifact-references

Conversation

@mys007
Copy link
Contributor

@mys007 mys007 commented Oct 6, 2025

PR Checklist

  • Use descriptive commit messages.
  • Provide tests for your changes.
  • Update any related documentation and include any relevant screenshots.
  • Check if changes need to be made to docs (README or any guides in /docs/).
  • Reflect the changes you made in the changelog.

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Fix bug which crashes code when WANDB_ADDITIONAL_ARTIFACT_REFERENCES is not set (=nearly any time), introduced in #79 .

Related Tickets & Documents

  • Related Issue #
  • Closes #

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes, a note
on the hardware and config this has been tested on, as well as any relevant
additional information.

Added/updated tests?

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

[optional] Are there any post deployment tasks we need to perform?

@mys007 mys007 enabled auto-merge (squash) October 6, 2025 22:47
@mys007 mys007 added bug Something isn't working and removed bug Something isn't working labels Oct 6, 2025
Copy link
Contributor

@dylan-rodriquez dylan-rodriquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mys007 mys007 merged commit c2d66ec into main Oct 7, 2025
13 of 17 checks passed
@mys007 mys007 deleted the fix-additional-artifact-references branch October 7, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants