Add WandbUploader and refactored HFUploader#87
Merged
Conversation
mys007
commented
Oct 8, 2025
mys007
commented
Oct 8, 2025
benureau
reviewed
Oct 9, 2025
benureau
reviewed
Oct 9, 2025
Contributor
|
is there an example run we can look at where the artifacts are uploaded? |
benureau
approved these changes
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
/docs/).What type of PR is this? (check all applicable)
Description
Add
WandbUploaderfor uploading results as W&B artifact:register_artifact_upload_function.Refactor
HFProcessorintoHFUploader. This shares the unified base class withWandbUploader, is objectively way less spaghetti and has more meaningful unit tests.Modify output directory so that the hash does not include irrelevant info (e.g. times, paths). Bonus: if new fields are introduced to
EvalConfig, it does not necessarily lead to new hashes.Add option to delete local output directory if upload succeeds. This may help to clear unnecessary local disk space if results will be available elsewhere anyway.
TODO / in progress: tests for
WandbUploaderRelated Tickets & Documents
QA Instructions, Screenshots, Recordings
Please replace this line with instructions on how to test your changes, a note
on the hardware and config this has been tested on, as well as any relevant
additional information.
Added/updated tests?
have not been included
[optional] Are there any post deployment tasks we need to perform?