fix: harden qdrant restore script and align restore .env example#110
Merged
bennotieno merged 1 commit intoMay 19, 2026
Merged
Conversation
Follow-up to feat/auto-fetch-collections-from-s3 with three small fixes surfaced during review. - track_collection: skip the read loop when the jq result is empty. Bash here-strings always append a newline, so `done <<< ""` would otherwise iterate once with an empty item and write a bogus `host,` line to $QDRANT_COLLECTIONS_FILE. Affects `get_coll` against an empty source. - generate_snapshot_file_from_s3: fix word order in the non-error exit message so the filename lands in the correct position. - UPGRADE-OPERATIONS.md restore example: set QDRANT_SOURCE_HOSTS="" to match the new restore-from-S3-only contract used by the k8s manifests; move the port-forward note to QDRANT_RESTORE_HOSTS where it belongs. - Sync configmap-script.yaml via config_map_updater.sh. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
bennotieno
approved these changes
May 19, 2026
bennotieno
merged commit 5e35d27
into
feat/auto-fetch-collections-from-s3
3 checks passed
tobias-pfaffelmoser-aa
added a commit
that referenced
this pull request
May 19, 2026
Follow-up to feat/auto-fetch-collections-from-s3 with three small fixes surfaced during review. - track_collection: skip the read loop when the jq result is empty. Bash here-strings always append a newline, so `done <<< ""` would otherwise iterate once with an empty item and write a bogus `host,` line to $QDRANT_COLLECTIONS_FILE. Affects `get_coll` against an empty source. - generate_snapshot_file_from_s3: fix word order in the non-error exit message so the filename lands in the correct position. - UPGRADE-OPERATIONS.md restore example: set QDRANT_SOURCE_HOSTS="" to match the new restore-from-S3-only contract used by the k8s manifests; move the port-forward note to QDRANT_RESTORE_HOSTS where it belongs. - Sync configmap-script.yaml via config_map_updater.sh.
tobias-pfaffelmoser-aa
added a commit
that referenced
this pull request
May 19, 2026
* feat: auto-fetch-collections-from-s3 * update documentation * Update ConfigMap with latest script changes * fix: harden qdrant restore script and align restore .env example (#110) Follow-up to feat/auto-fetch-collections-from-s3 with three small fixes surfaced during review. - track_collection: skip the read loop when the jq result is empty. Bash here-strings always append a newline, so `done <<< ""` would otherwise iterate once with an empty item and write a bogus `host,` line to $QDRANT_COLLECTIONS_FILE. Affects `get_coll` against an empty source. - generate_snapshot_file_from_s3: fix word order in the non-error exit message so the filename lands in the correct position. - UPGRADE-OPERATIONS.md restore example: set QDRANT_SOURCE_HOSTS="" to match the new restore-from-S3-only contract used by the k8s manifests; move the port-forward note to QDRANT_RESTORE_HOSTS where it belongs. - Sync configmap-script.yaml via config_map_updater.sh. --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Tobias Pfaffelmoser <tobias.pfaffelmoser@ext.aleph-alpha.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to feat/auto-fetch-collections-from-s3 with three small fixes
done <<< ""would otherwise iterate once with an empty item and write a bogushost,line to $QDRANT_COLLECTIONS_FILE. Affectsget_collagainst an empty source.