Added Java 9 Modules support#12
Merged
AlessioDP merged 1 commit intoAlessioDP:masterfrom Apr 11, 2023
4drian3d:feat/modules-support
Merged
Added Java 9 Modules support#12AlessioDP merged 1 commit intoAlessioDP:masterfrom 4drian3d:feat/modules-support
AlessioDP merged 1 commit intoAlessioDP:masterfrom
4drian3d:feat/modules-support
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if you try to use libby as a dependency in a project that uses Java 9 or higher modules, it will give an error because libby does not declare any module and therefore is in the unnamed module and cannot be used in projects that implement this functionality.
In this pull request I add support for this by implementing automatic modules in libby without losing compatibility with older versions of Java (Java 8)