Skip to content

[WIP] Improve templates#201

Merged
AlexInLog merged 16 commits into
mainfrom
improve_templates
Aug 2, 2022
Merged

[WIP] Improve templates#201
AlexInLog merged 16 commits into
mainfrom
improve_templates

Conversation

@AlexInLog

Copy link
Copy Markdown
Owner

No description provided.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

Comment thread src/tests/test_observer.cpp
Comment thread src/tests/test_observer.cpp
@codecov

codecov Bot commented Aug 1, 2022

Copy link
Copy Markdown

Codecov Report

Merging #201 (da2569d) into main (b1afd51) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #201      +/-   ##
==========================================
+ Coverage   99.62%   99.71%   +0.08%     
==========================================
  Files          83       83              
  Lines        1072     1055      -17     
==========================================
- Hits         1068     1052      -16     
+ Misses          4        3       -1     
Impacted Files Coverage Δ
src/rpp/rpp/observables/blocking_observable.hpp 100.00% <ø> (ø)
src/rpp/rpp/observables/interface_observable.hpp 100.00% <ø> (ø)
src/rpp/rpp/operators/buffer.hpp 100.00% <ø> (ø)
src/rpp/rpp/operators/concat.hpp 100.00% <ø> (ø)
src/rpp/rpp/operators/details/combining_utils.hpp 100.00% <ø> (ø)
src/rpp/rpp/operators/filter.hpp 100.00% <ø> (ø)
src/rpp/rpp/operators/map.hpp 100.00% <ø> (ø)
src/rpp/rpp/operators/observe_on.hpp 100.00% <ø> (ø)
src/rpp/rpp/operators/repeat.hpp 100.00% <ø> (ø)
src/rpp/rpp/operators/switch_on_next.hpp 100.00% <ø> (ø)
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@github-actions

github-actions Bot commented Aug 1, 2022

Copy link
Copy Markdown
Contributor

Linux CLANG

Observable construction

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
Specific observable construction 0.30ns 0.335054 0.88 0.30ns
Dynamic observable construction 25.68ns 29.1394 0.88 21.80ns
Specific observable construction + as_dynamic 25.73ns 29.1678 0.88 21.26ns

Observable lift

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
Specific observable lift specific observer 63.06ns 72.2066 0.87 255.26ns
Specific observable lift dynamic observer 83.86ns 94.9255 0.88 268.50ns
Dynamic observable lift specific observer 136.18ns 162.454 0.84 309.33ns
Dynamic observable lift dynamic observer 144.31ns 173.258 0.83 285.35ns

Observable subscribe

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
Specific observable subscribe specific observer 39.88ns 45.2012 0.88 252.48ns
Specific observable subscribe dynamic observer 53.00ns 60.0551 0.88 258.50ns
Dynamic observable subscribe specific observer 102.25ns 119.786 0.85 288.53ns
Dynamic observable subscribe dynamic observer 97.62ns 113.213 0.86 278.11ns

Observable subscribe #2

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
Specific observable subscribe lambda 39.93ns 45.2403 0.88 256.68ns
Dynamic observable subscribe lambda 97.20ns 109.796 0.89 289.90ns
Specific observable subscribe lambda without subscription 39.92ns 45.2057 0.88 253.53ns
Dynamic observable subscribe lambda without subscription 96.96ns 109.851 0.88 289.30ns
Specific observable subscribe specific subscriber 14.78ns 16.7544 0.88 199.25ns
Dynamic observable subscribe specific subscriber 70.33ns 78.6571 0.89 237.87ns
Specific observable subscribe dynamic observer 14.79ns 16.7443 0.88 209.29ns
Dynamic observable subscribe dynamic observer 57.29ns 63.1864 0.91 230.26ns

Observer construction

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
Specific observer construction 0.30ns 0.670258 0.44 0.30ns
Dynamic observer construction 25.75ns 29.1363 0.88 18.66ns
Specific observer construction + as_dynamic 25.77ns 29.1539 0.88 19.06ns

OnNext

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
Specific observer OnNext 0.59ns 0.668612 0.88 0.59ns
Dynamic observer OnNext 1.48ns 1.67902 0.88 2.19ns

Subscriber construction

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
Make subsriber 27.78ns 32.4348 0.86 56.80ns
Make copy of subscriber 14.78ns 16.7411 0.88 4.17ns
Transform subsriber to dynamic 38.35ns 46.5185 0.82 22.91ns

Subscription

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
composite_subscription create 27.77ns 31.4258 0.88 45.50ns
composite_subscription add 40.25ns 45.374 0.89 18.12ns
composite_subscription unsubscribe 5.32ns 6.02161 0.88 9.44ns

buffer

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
buffer 15.19ns 16.889 0.90 40.83ns
sending of values from observable via buffer to subscriber 4.14ns 8.89709 0.46 24.04ns

chains creation test

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
long non-state chain creation + subscribe 159.98ns 204.846 0.78 280.87ns
long stateful chain creation + subscribe 443.21ns 541.524 0.82 5141.47ns

concat

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
concat 15.32ns 17.37 0.88 111.93ns
concat_with 68.70ns 79.1222 0.87 263.50ns

distinct_until_changed

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
distinct_until_changed construction from observable via dot + subscribe 86.60ns 118.63 0.73 220.78ns
sending of values from observable via distinct_until_changed to subscriber 0.89ns 3.35133 0.26 1.77ns

foundamental sources

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
empty 14.79ns 16.76 0.88 31.95ns
error 43.74ns 49.2272 0.89 67.97ns
never 14.78ns 16.7147 0.88 206.47ns

from

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
from vector with int 24.52ns 27.8298 0.88 49.76ns

just

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
just send int 14.83ns 16.7577 0.89 31.26ns
just send variadic 14.80ns 16.7645 0.88 37.53ns

map

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
map construction from observable via dot + subscribe 50.80ns 70.9536 0.72 215.25ns
sending of values from observable via map to subscriber 1.18ns 7.35555 0.16 1.33ns

merge

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
merge 15.31ns 17.3868 0.88 111.59ns
merge_with 69.99ns 79.3772 0.88 263.62ns

observe_on

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
observe_on construction from observable via dot + subscribe 639.04ns 738.214 0.87 2395.05ns
sending of values from observable via observe_on to subscriber 120.87ns 142.464 0.85 171.14ns

publish_subject callbacks

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
on_next 21.57ns 24.4285 0.88 9.22ns
on_error 2.15ns 2.0184 1.07 16.89ns
on_completed 1.78ns 2.48816 0.72 0.59ns

publish_subject routines

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
construct 147.94ns 169.696 0.87 158.13ns
get_observable 23.30ns 29.1034 0.80 44.48ns
get_subscriber 51.34ns 62.2274 0.82 11.39ns

repeat

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
repeat construction from observable via dot + subscribe 16.31ns 18.4734 0.88 9.25ns

scan

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
scan construction from observable via dot + subscribe 84.90ns 111.45 0.76 264.02ns
sending of values from observable via scan to subscriber 1.18ns 5.73695 0.21 1.77ns

switch_on_next

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
switch_on_next construction from observable via dot + subscribe 1338.53ns 1595.52 0.84 2687.16ns
sending of values from observable via switch_on_next to subscriber 346.01ns 409.804 0.84 566.87ns

window

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
window 16.00ns 17.8053 0.90 41.76ns
sending of values from observable via window to subscriber 452.59ns 528.27 0.86 320.41ns

with_latest_from

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
with_latest_from construction from observable via dot + subscribe 562.34ns 658.01 0.85 1092.08ns
sending of values from observable via with_latest_from to subscriber 15.67ns 24.0703 0.65 2.66ns

Linux GCC

Observable construction

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
Specific observable construction 0.29ns 0.335614 0.86 0.33ns
Dynamic observable construction 27.96ns 31.5343 0.89 22.87ns
Specific observable construction + as_dynamic 27.80ns 31.5442 0.88 23.40ns

Observable lift

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
Specific observable lift specific observer 76.75ns 89.1323 0.86 346.49ns
Specific observable lift dynamic observer 109.03ns 119.411 0.91 359.39ns
Dynamic observable lift specific observer 158.38ns 168.916 0.94 398.61ns
Dynamic observable lift dynamic observer 168.34ns 187.341 0.90 377.28ns

Observable subscribe

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
Specific observable subscribe specific observer 39.82ns 47.1294 0.85 337.81ns
Specific observable subscribe dynamic observer 58.48ns 60.6225 0.96 342.41ns
Dynamic observable subscribe specific observer 112.93ns 123.516 0.91 380.52ns
Dynamic observable subscribe dynamic observer 109.77ns 122.31 0.90 348.88ns

Observable subscribe #2

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
Specific observable subscribe lambda 45.25ns 48.5477 0.93 335.95ns
Dynamic observable subscribe lambda 99.10ns 122.009 0.81 383.13ns
Specific observable subscribe lambda without subscription 39.89ns 48.5428 0.82 335.34ns
Dynamic observable subscribe lambda without subscription 99.51ns 123.739 0.80 378.51ns
Specific observable subscribe specific subscriber 14.79ns 16.7474 0.88 276.38ns
Dynamic observable subscribe specific subscriber 71.30ns 84.4158 0.84 323.71ns
Specific observable subscribe dynamic observer 14.77ns 16.7386 0.88 278.43ns
Dynamic observable subscribe dynamic observer 56.75ns 68.3108 0.83 293.43ns

Observer construction

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
Specific observer construction 0.30ns 0.33499 0.88 0.33ns
Dynamic observer construction 27.83ns 31.4286 0.89 21.38ns
Specific observer construction + as_dynamic 27.90ns 31.4679 0.89 21.09ns

OnNext

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
Specific observer OnNext 0.30ns 0.335336 0.88 0.34ns
Dynamic observer OnNext 1.77ns 2.01221 0.88 1.73ns

Subscriber construction

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
Make subsriber 27.98ns 37.5768 0.74 61.89ns
Make copy of subscriber 14.76ns 16.757 0.88 4.44ns
Transform subsriber to dynamic 39.12ns 44.8581 0.87 26.87ns

Subscription

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
composite_subscription create 31.20ns 30.8405 1.01 58.08ns
composite_subscription add 42.33ns 46.4707 0.91 17.57ns
composite_subscription unsubscribe 8.37ns 8.3287 1.01 11.03ns

buffer

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
buffer 17.21ns 17.236 1.00 59.70ns
sending of values from observable via buffer to subscriber 5.37ns 12.2202 0.44 30.79ns

chains creation test

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
long non-state chain creation + subscribe 220.42ns 231.351 0.95 624.82ns
long stateful chain creation + subscribe 539.03ns 589.323 0.91 5737.16ns

concat

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
concat 17.47ns 18.1098 0.96 147.90ns
concat_with 87.22ns 88.5819 0.98 348.86ns

distinct_until_changed

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
distinct_until_changed construction from observable via dot + subscribe 110.35ns 128.637 0.86 366.84ns
sending of values from observable via distinct_until_changed to subscriber 1.34ns 4.11706 0.33 1.34ns

foundamental sources

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
empty 16.76ns 16.7525 1.00 46.54ns
error 49.51ns 50.6314 0.98 85.15ns
never 16.71ns 16.7115 1.00 273.74ns

from

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
from vector with int 29.63ns 30.8187 0.96 68.45ns

just

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
just send int 16.76ns 16.7711 1.00 49.99ns
just send variadic 16.78ns 16.7897 1.00 47.37ns

map

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
map construction from observable via dot + subscribe 64.63ns 76.4942 0.84 354.59ns
sending of values from observable via map to subscriber 1.68ns 8.13601 0.21 2.35ns

merge

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
merge 17.58ns 17.4438 1.01 146.44ns
merge_with 90.55ns 87.0174 1.04 348.85ns

observe_on

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
observe_on construction from observable via dot + subscribe 739.89ns 810.979 0.91 2881.63ns
sending of values from observable via observe_on to subscriber 137.11ns 174.492 0.79 243.70ns

publish_subject callbacks

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
on_next 22.44ns 24.11 0.93 12.16ns
on_error 2.82ns 1.00939 2.80 16.84ns
on_completed 0.67ns 0.505076 1.34 1.35ns

publish_subject routines

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
construct 180.37ns 174.277 1.03 172.87ns
get_observable 29.48ns 29.4794 1.00 50.37ns
get_subscriber 57.27ns 66.3465 0.86 23.16ns

repeat

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
repeat construction from observable via dot + subscribe 18.69ns 18.9623 0.99 23.37ns

scan

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
scan construction from observable via dot + subscribe 109.21ns 119.936 0.91 395.29ns
sending of values from observable via scan to subscriber 1.01ns 4.16337 0.24 1.59ns

switch_on_next

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
switch_on_next construction from observable via dot + subscribe 1636.03ns 1706.02 0.96 4428.19ns
sending of values from observable via switch_on_next to subscriber 424.75ns 441.806 0.96 1071.62ns

window

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
window 18.04ns 18.6303 0.97 60.61ns
sending of values from observable via window to subscriber 558.60ns 577.658 0.97 420.20ns

with_latest_from

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
with_latest_from construction from observable via dot + subscribe 680.73ns 724.443 0.94 1475.02ns
sending of values from observable via with_latest_from to subscriber 17.74ns 25.7468 0.69 4.19ns

Windows MSVC

Observable construction

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
Specific observable construction 1.81ns 1.81353 1.00 0.81ns
Dynamic observable construction 116.44ns 98.026 1.19 170.76ns
Specific observable construction + as_dynamic 103.93ns 98.0158 1.06 156.36ns

Observable lift

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
Specific observable lift specific observer 162.24ns 168.506 0.96 1476.14ns
Specific observable lift dynamic observer 199.25ns 200.788 0.99 1546.00ns
Dynamic observable lift specific observer 306.36ns 324.656 0.94 1726.11ns
Dynamic observable lift dynamic observer 255.39ns 267.588 0.95 1600.50ns

Observable subscribe

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
Specific observable subscribe specific observer 128.26ns 125.548 1.02 1414.64ns
Specific observable subscribe dynamic observer 142.37ns 139.964 1.02 1470.95ns
Dynamic observable subscribe specific observer 269.80ns 262.534 1.03 1669.26ns
Dynamic observable subscribe dynamic observer 205.56ns 196.409 1.05 1519.62ns

Observable subscribe #2

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
Specific observable subscribe lambda 130.61ns 125.878 1.04 1457.19ns
Dynamic observable subscribe lambda 238.30ns 260.317 0.92 1638.00ns
Specific observable subscribe lambda without subscription 129.13ns 126.296 1.02 1428.09ns
Dynamic observable subscribe lambda without subscription 261.37ns 260.772 1.00 1646.95ns
Specific observable subscribe specific subscriber 20.11ns 20.1894 1.00 1066.06ns
Dynamic observable subscribe specific subscriber 153.27ns 153.73 1.00 1250.19ns
Specific observable subscribe dynamic observer 20.13ns 20.1308 1.00 1108.48ns
Dynamic observable subscribe dynamic observer 77.25ns 77.7957 0.99 1159.00ns

Observer construction

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
Specific observer construction 1.91ns 0.91783 2.09 1.80ns
Dynamic observer construction 98.08ns 98.4267 1.00 138.19ns
Specific observer construction + as_dynamic 105.66ns 99.1926 1.07 142.82ns

OnNext

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
Specific observer OnNext 0.82ns 0.804304 1.02 0.87ns
Dynamic observer OnNext 2.42ns 2.28526 1.06 2.45ns

Subscriber construction

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
Make subsriber 102.53ns 105.152 0.98 428.85ns
Make copy of subscriber 20.12ns 38.5494 0.52 40.79ns
Transform subsriber to dynamic 115.37ns 115.474 1.00 186.81ns

Subscription

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
composite_subscription create 104.08ns 107.0 0.97 421.65ns
composite_subscription add 76.14ns 75.4796 1.01 76.57ns
composite_subscription unsubscribe 10.91ns 10.0416 1.09 30.73ns

buffer

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
buffer 30.70ns 30.3221 1.01 296.97ns
sending of values from observable via buffer to subscriber 7.42ns 9.93563 0.75 113.11ns

chains creation test

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
long non-state chain creation + subscribe 240.66ns 281.445 0.86 1906.06ns
long stateful chain creation + subscribe 883.54ns 857.914 1.03 3755.38ns

concat

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
concat 34.31ns 42.1602 0.81 849.94ns
concat_with 366.75ns 367.387 1.00 1720.65ns

distinct_until_changed

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
distinct_until_changed construction from observable via dot + subscribe 207.83ns 215.917 0.96 1530.71ns
sending of values from observable via distinct_until_changed to subscriber 3.07ns 4.58304 0.67 4.70ns

foundamental sources

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
empty 20.03ns 20.1609 0.99 234.10ns
error 57.49ns 56.8068 1.01 271.39ns
never 20.19ns 20.2799 1.00 1045.55ns

from

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
from vector with int 101.53ns 100.639 1.01 321.65ns

just

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
just send int 24.22ns 23.9471 1.01 231.61ns
just send variadic 25.70ns 25.0966 1.02 235.82ns

map

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
map construction from observable via dot + subscribe 82.66ns 92.2997 0.90 1491.46ns
sending of values from observable via map to subscriber 4.12ns 7.43068 0.55 8.39ns

merge

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
merge 34.31ns 45.1692 0.76 807.41ns
merge_with 360.83ns 369.521 0.98 1720.58ns

observe_on

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
observe_on construction from observable via dot + subscribe 1107.88ns 1136.31 0.97 6741.80ns
sending of values from observable via observe_on to subscriber 168.40ns 172.901 0.97 966.33ns

publish_subject callbacks

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
on_next 24.29ns 24.0031 1.01 39.31ns
on_error 3.45ns 2.84886 1.21 23.16ns
on_completed 3.03ns 2.91461 1.04 0.83ns

publish_subject routines

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
construct 369.69ns 341.873 1.08 717.16ns
get_observable 31.35ns 31.0123 1.01 230.90ns
get_subscriber 68.88ns 60.3638 1.14 113.67ns

repeat

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
repeat construction from observable via dot + subscribe 30.09ns 33.0943 0.91 122.14ns

scan

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
scan construction from observable via dot + subscribe 192.16ns 204.327 0.94 1875.52ns
sending of values from observable via scan to subscriber 7.19ns 11.6972 0.61 11.28ns

switch_on_next

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
switch_on_next construction from observable via dot + subscribe 3147.00ns 3224.0 0.98 15184.30ns
sending of values from observable via switch_on_next to subscriber 797.75ns 814.0 0.98 3924.22ns

window

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
window 34.93ns 34.0074 1.03 342.55ns
sending of values from observable via window to subscriber 992.83ns 988.969 1.00 1967.56ns

with_latest_from

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
with_latest_from construction from observable via dot + subscribe 1288.10ns 1307.41 0.99 4669.17ns
sending of values from observable via with_latest_from to subscriber 36.11ns 37.5519 0.96 8.11ns

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

Comment thread src/rpp/rpp/subscribers/specific_subscriber.hpp Outdated
Comment thread src/rpp/rpp/subscribers/details/subscriber_base.hpp Outdated
@sonarqubecloud

sonarqubecloud Bot commented Aug 2, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 13 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@AlexInLog AlexInLog merged commit 5efd260 into main Aug 2, 2022
@AlexInLog AlexInLog deleted the improve_templates branch August 2, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant