Skip to content

add dynamic connectable #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexInLog merged 1 commit into from
Nov 2, 2024
Merged

add dynamic connectable #672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/rpp/rpp/observables/dynamic_observable.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
#pragma once

#include <rpp/observables/fwd.hpp>
#include <rpp/subjects/fwd.hpp>

#include <rpp/observables/observable.hpp>
#include <rpp/observers/dynamic_observer.hpp>
Expand Down Expand Up @@ -101,4 +102,7 @@ namespace rpp
{
}
};

template<typename Subject>
using dynamic_connectable_observable = connectable_observable<rpp::dynamic_observable<rpp::subjects::utils::extract_subject_type_t<Subject>>, Subject>;
} // namespace rpp
22 changes: 14 additions & 8 deletions src/tests/rpp/test_connectable_observable.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,11 @@
#include <doctest/doctest.h>

#include <rpp/observables/connectable_observable.hpp>
#include <rpp/observables/dynamic_observable.hpp>
#include <rpp/observers/mock_observer.hpp>
#include <rpp/operators/map.hpp>
#include <rpp/operators/multicast.hpp>
#include <rpp/operators/publish.hpp>
#include <rpp/sources/just.hpp>
#include <rpp/subjects/publish_subject.hpp>

Expand Down Expand Up @@ -78,6 +80,8 @@ TEST_CASE("connectable observable")
};
SUBCASE("connectable created manually")
test(rpp::connectable_observable{source, rpp::subjects::publish_subject<int>{}});
SUBCASE("dynamic_connectable created manually")
test(rpp::dynamic_connectable_observable<rpp::subjects::publish_subject<int>>{source, rpp::subjects::publish_subject<int>{}});
SUBCASE("connectable created via multicast")
test(source | rpp::ops::multicast(rpp::subjects::publish_subject<int>{}));
SUBCASE("connectable created via templated multicast")
Expand Down Expand Up @@ -164,6 +168,8 @@ TEST_CASE("connectable observable")
};
SUBCASE("connectable created manually")
test(rpp::connectable_observable{source.get_observable(), rpp::subjects::publish_subject<int>{}});
SUBCASE("dynamic_connectable created manually")
test(rpp::dynamic_connectable_observable<rpp::subjects::publish_subject<int>>{source.get_observable(), rpp::subjects::publish_subject<int>{}});
SUBCASE("connectable created via multicast")
test(source.get_observable() | rpp::ops::multicast(rpp::subjects::publish_subject<int>{}));
SUBCASE("connectable created via templated multicast")
Expand All @@ -172,14 +178,14 @@ TEST_CASE("connectable observable")
SUBCASE("observable")
{
auto source = rpp::source::just(1);
// SUBCASE("call publish on it")
// {
// auto published = source.publish();
// SUBCASE("published observable is same as Connectable with publish_subject")
// {
// static_assert(rpp::constraint::decayed_same_as<decltype(published), rpp::connectable_observable<int, rpp::subjects::publish_subject<int>, decltype(source)>>);
// }
// }
SUBCASE("call publish on it")
{
auto published = source | rpp::ops::publish();
SUBCASE("published observable is same as Connectable with publish_subject")
{
static_assert(rpp::constraint::decayed_same_as<decltype(published), rpp::connectable_observable<decltype(source), rpp::subjects::publish_subject<int>>>);
}
}
SUBCASE("call multicast on it with publish_subject")
{
auto published = source | rpp::ops::multicast(rpp::subjects::publish_subject<int>{});
Expand Down