Added new audit prompt #564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a centralized constants module to eliminate magic numbers throughout the codebase, improving maintainability and testability. The changes also include TypeScript type improvements, accessibility fixes, and proper cleanup of timeouts to prevent memory leaks.
Key Changes:
- Created a new
src/constants/index.tsmodule with categorized constants for delays, thresholds, network settings, and animations - Replaced hardcoded values across components with named constants
- Added proper TypeScript types and documentation
- Implemented cleanup logic for debounced functions and timeouts
Reviewed changes
Copilot reviewed 15 out of 18 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/constants/index.ts | New centralized constants module with delays, thresholds, network settings, and animation durations |
| src/util/isNetworkFast.ts | Replaced magic numbers with NETWORK constants and added proper TypeScript types |
| src/util/isNetworkFast.test.ts | Updated tests to use NETWORK constants |
| src/helpers/ascii.ts | Replaced hardcoded debounce delay with DELAYS constant |
| src/configs/firebase.ts | Added proper TypeScript types and documentation |
| src/components/projects/ProjectsGrid.tsx | Replaced magic number with DELAYS constant and added cleanup logic |
| src/components/banner/Avatar.tsx | Replaced magic numbers with constants and added debounce cleanup |
| src/components/Stars/StarsBackground.tsx | Improved TypeScript types and added timeout cleanup logic |
| src/app/not-found.tsx | Fixed accessibility attribute typo |
| src/app/not-found.test.tsx | Updated test to match corrected aria-label |
| package.json | Updated caniuse-lite and globals dependencies |
| docs/architecture/index.md | Added constants subsystem to architecture documentation |
| docs/architecture/constants.md | Comprehensive documentation for the new constants module |
| .github/prompts/audit-quality.md | New prompt for codebase quality audits |
| .github/prompts/audit-docs.md | Removed duplicate separator |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.