Implement Phase 1: maggraph.toml configuration loader#2
Merged
Conversation
- Add Rust workspace with maggraph lib and maggraph-cli binary - Implement TOML schema for [storage], [lakehouse], and [sync] - Validate config fields and resolve root_path relative to config file - Support optional graph root initialization with .maggraph metadata dir - Add examples/basic and examples/lakehouse fixtures with sample nodes - Add unit tests for valid/invalid configs and path resolution - Add CI workflow (fmt, clippy, test) and update planning progress Co-authored-by: Alex Merced <alex@alexmerced.dev>
Co-authored-by: Alex Merced <alex@alexmerced.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements Phase 1 — Configuration & filesystem layout from the implementation plan. Also includes the minimal Rust workspace scaffolding required for the config module (partial Phase 0).
What's included
Config module (
maggraph::config)[storage],[lakehouse],[sync]StorageMode(local|lakehouse) andSyncRole(leader|follower)root_pathresolved relative to the config file directoryinitialize_graph_root()to create the graph root and optional.maggraph/metadata directoryExamples
examples/basic/— local-mode config + two-node sample graphexamples/lakehouse/— PRD-style lakehouse + follower configCLI stub
maggraph --config <path> [--init]loads and validates config (foundation for Phase 6)Tests & CI
fmt,clippy,testAcceptance criteria (Phase 1)
root_pathcorrectlymaggraph.toml+ sample graph inexamples/Try it
cargo test cargo run -p maggraph-cli -- --config examples/basic/maggraph.toml cargo run -p maggraph-cli -- --config examples/basic/maggraph.toml --initProgress
Updated
planning/PROGRESS.md— Phase 1 marked complete; Phase 0 partially complete (workspace, CI, error types).Slack Thread