fix: closing websocket connection returns invalid status code#74
Merged
AlexStocks merged 1 commit intoAlexStocks:masterfrom Nov 20, 2023
jayliao2025:fix-close-websocket-invalid-status-code
Merged
fix: closing websocket connection returns invalid status code#74AlexStocks merged 1 commit intoAlexStocks:masterfrom jayliao2025:fix-close-websocket-invalid-status-code
AlexStocks merged 1 commit intoAlexStocks:masterfrom
jayliao2025:fix-close-websocket-invalid-status-code
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #74 +/- ##
==========================================
+ Coverage 70.26% 70.42% +0.15%
==========================================
Files 7 7
Lines 1490 1491 +1
==========================================
+ Hits 1047 1050 +3
+ Misses 337 336 -1
+ Partials 106 105 -1 ☔ View full report in Codecov by Sentry. |
Owner
|
good job |
Lvnszn
reviewed
Nov 19, 2023
AlexStocks
approved these changes
Nov 20, 2023
Lvnszn
approved these changes
Nov 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does: 修复异常关闭连接问题
Which issue(s) this PR fixes: 服务端关闭连接时，客户端异常关闭 #73
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: